fix: move awsacfg resource creation from Helm chart to controller #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha94
reviewed
Mar 2, 2023
@kbeniwal Please update this behavior in the docs. |
pns-nirmata
reviewed
Mar 8, 2023
pns-nirmata
reviewed
Mar 8, 2023
anusha94
reviewed
Mar 8, 2023
pns-nirmata
reviewed
Mar 13, 2023
| clusterRegion := getClusterRegion() | ||
| adapterName := getAdapterName() | ||
| adapterNamespace := getAdapterNamespace() | ||
| return r.Create(context.TODO(), &securityv1alpha1.AWSAdapterConfig{ |
There was a problem hiding this comment.
If any of the above are empty, then don't create instead of failing and exiting.
There was a problem hiding this comment.
Done. I moved the required parameters and their error handling to the main file, so that we can right away return if all required params are not present.
pns-nirmata
reviewed
Mar 15, 2023
pns-nirmata
approved these changes
Mar 15, 2023
pns-nirmata
approved these changes
Mar 15, 2023
This was referenced Mar 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #58.
Note: The creation of the
awsacfgresource has been removed from the Helm Chart. Therefore, the Helm Chart will not handle the deletion of this resource. Even after runninghelm uninstall, theawsacfgresource will still be present in the Kubernetes cluster, and it is the responsibility of the user to manually delete it if needed. Similar case for the pod deletion, awsacfg resource will not be deleted.