Removed refs to values.yaml and more doc changes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha94
reviewed
Dec 2, 2022
|
|
||
| 2. Add the Kyverno AWS Adapter Helm repository. | ||
| ```console | ||
| helm repo add kyverno-aws-adapter https://nirmata.github.io/kyverno-aws-adapter/ | ||
| helm repo update kyverno-aws-adapter | ||
| ``` | ||
|
|
||
| 3. Install the Helm chart in an appropriate namespace, providing other parameters as described in the [Values](#values) section. | ||
| 3. Install the Helm chart in an appropriate namespace, providing other parameters as described in the [Values](#values) section. Parameters `roleArn`, `eksCluster.name`, `eksCluster.region` are required. |
There was a problem hiding this comment.
As suggested in the TODO of this PR #35 , maybe we can move to a separate local-dev.md file. And it would be actually nice to point to values.yaml, because its local development.
You can have instructions for someone to build and run the controllers manually too.
There was a problem hiding this comment.
Does the above change look ok for the helm install though? Because, there is no chart.yaml, user could use -set or -f.
Raised an issue to have a dev guide #38.
anusha94
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.