Remove imagepullsecret after open sourcing

[pns-nirmata]

Since the repo is open source, we don't need imagepull secrets.

Fixes #30

[eddycharly]

Some users will mirror the image on a private repo though.

[anusha94]

Some users will mirror the image on a private repo though.

That's a good use case. Then can we add that appropriate comment for the field?

Something like "registry credentials if pulling from your private repository" ?

[eddycharly]

Some users will mirror the image on a private repo though.

That's a good use case. Then can we add that appropriate comment for the field?

Something like "registry credentials if pulling from your private repository" ?

We should introduce imagePullSecrets as a value, users won't put the credentials in clear text here. They will want to reference an existing secret in the cluster (bring your own image pull secret ;-)

[anusha94]

bring your own image pull secret

@eddycharly Love it!

Let's open a new issue for it and address it separately. We can go ahead with removing this IMO.

[eddycharly]

Yeah, this is trivial to add.

[eddycharly]

@anusha94 see #33

[shreemaan-abhishek]

specified the role's ARN in the roleArn field inside values.yaml file.

Where do I get this values.yaml file from? 🤔

[pns-nirmata]

Yes. The documentation needs to be changed. To specify the roleArn at helm install time.

[anusha94]

I think we can close this PR in favor of #33

[pns-nirmata]

Closing this PR in favour of #33