Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sublimelinter4 #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for sublimelinter4 #35

wants to merge 1 commit into from

Conversation

xolom
Copy link

@xolom xolom commented Feb 1, 2018

settings mapping doesn't work anymore

settings mapping doesn't work anymore
@braver
Copy link

braver commented Mar 2, 2018

@kaste can you verify that this PR is correct? If so, I think I'll just commence the takeover.

Unless @nirm03 doesn't want us to take over "maintenance" of this repo of course, but it would be nice to fix it today.

@kaste
Copy link

kaste commented Mar 2, 2018

From my point of view, this is okay. I could bikeshed. But @schreda did this and he/she probably thinks this is okay too. So we're at least two. 😄

@braver
Copy link

braver commented Mar 2, 2018

Awesome 🎉

@braver
Copy link

braver commented Mar 2, 2018

This plugin, with this PR merged, is now available here: https://github.com/SublimeLinter/SublimeLinter-clang. I published 1.1.0, should trickle through package control soon.

@Optiligence
Copy link
Contributor

Would’ve been nice if you would’ve forked it officially, so its heritage can be traced automatically…

@braver
Copy link

braver commented Mar 3, 2018

Forks have several limitations, like you can’t search the code and it complicates merge requests.

@Optiligence
Copy link
Contributor

alright, sad tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants