Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): selectable compression kind #50

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

anatawa12
Copy link
Collaborator

What

Closes #17
Closes #19

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12
Copy link
Collaborator Author

anatawa12 commented Aug 16, 2023

元が非可逆なら非可逆圧縮かかることを意図してるとして、非可逆で実装してます

packages/frontend/src/scripts/upload/compress-config.ts Outdated Show resolved Hide resolved
packages/frontend/src/scripts/upload/compress-config.ts Outdated Show resolved Hide resolved
packages/frontend/src/scripts/upload/compress-config.ts Outdated Show resolved Hide resolved
packages/frontend/src/scripts/upload/compress-config.ts Outdated Show resolved Hide resolved
locales/ja-JP.yml Outdated Show resolved Hide resolved
Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 2nd

packages/frontend/src/scripts/upload/compress-config.ts Outdated Show resolved Hide resolved
packages/frontend/src/scripts/upload/compress-config.ts Outdated Show resolved Hide resolved
@Sayamame-beans
Copy link

他は問題無さそうに見えます

Co-authored-by: Sayamame-beans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

非可逆webp圧縮を行うオプションの追加 可逆圧縮のみ行うオプションの追加
2 participants