spec(backend/NoteCreateService): ローカルユーザーがまだ誰もフォローしていないリモートユーザーによる通知を引き起こす可能性のある投稿を拒否できるように (MisskeyIO#462) (patched) #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
これ有効無効envでいいの？という気持ちが少し |
|
このPRによるapi.jsonの差分 差分はこちら |
同じ気持ちです |
|
configにする？ |
…引き起こす可能性のある投稿を拒否できるように (MisskeyIO#462) Cherry-picked from 738b4d6, 1b3adcc, 33cb507, a27af00, 5c6236b Co-authored-by: Ebise Lutica <[email protected]> Co-authored-by: anatawa12 <[email protected]>
…UnfamiliarRemoteUsers
anatawa12
force-pushed
the
block-mentions-from-non-followed
branch
from
ec6c2a3 to
f93be69
Compare
|
した |
|
とりあえずこれをそのまま採用するという前提に立てば、configかサーバー側の設定項目雑に生やすかのどちらかかなぁ(実質前者のみ?)という感じでしょうか |
anatawa12
changed the title
|
metaに追加は面倒なのでconfigにしました。 |
|
(changelogのコンフリクト面倒なのでできればマージしたいのでreview急いでほしい) |
|
む… |
Sayamame-beans
requested changes
Feb 19, 2024
Co-authored-by: Sayamame-beans <[email protected]>
|
else Approve |
|
additional patchがあるっぽい |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from 738b4d6, 1b3adcc, 33cb507, a27af00, 5c6236b
What
Fixes #146
Why
Additional info (optional)
Checklist