Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Add git-archive support for setuptools_scm #609

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

effigies
Copy link
Contributor

Types of changes

  • Maintenance task: Add and test git-archive support

Summary

Versioneer permitted git archive to store some limited version information in the artifacts, such as those generated by GitHub. setuptools_scm needs special prodding to do this.

This adds and tests the feature. In the process, I've split the build and test stages from the main tests so that we can test different installation methods.

Checklist

  • I have added tests to cover my changes (if necessary)

@effigies effigies force-pushed the mnt/git-archive-support branch 2 times, most recently from f59e455 to 4da2504 Compare December 14, 2022 15:15
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 76.86% // Head: 80.43% // Increases project coverage by +3.56% 🎉

Coverage data is based on head (d89106b) compared to base (e27886d).
Patch coverage: 90.90% of modified lines in pull request are covered.

❗ Current head d89106b differs from pull request most recent head 890f5de. Consider uploading reports for the commit 890f5de to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   76.86%   80.43%   +3.56%     
==========================================
  Files          19       20       +1     
  Lines        4362     4391      +29     
  Branches     1260        0    -1260     
==========================================
+ Hits         3353     3532     +179     
- Misses        821      859      +38     
+ Partials      188        0     -188     
Flag Coverage Δ
unittests 80.43% <90.90%> (+3.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/conftest.py 72.22% <90.90%> (+25.79%) ⬆️
pydra/engine/workers.py 18.76% <0.00%> (ø)
pydra/__init__.py 90.47% <0.00%> (ø)
pydra/engine/task.py 87.69% <0.00%> (+0.92%) ⬆️
pydra/utils/messenger.py 95.89% <0.00%> (+1.36%) ⬆️
pydra/engine/graph.py 94.68% <0.00%> (+1.99%) ⬆️
pydra/utils/profiler.py 45.80% <0.00%> (+2.29%) ⬆️
pydra/engine/submitter.py 81.01% <0.00%> (+3.16%) ⬆️
pydra/engine/core.py 92.96% <0.00%> (+3.66%) ⬆️
pydra/engine/state.py 96.39% <0.00%> (+3.80%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies force-pushed the mnt/git-archive-support branch 2 times, most recently from 4480da2 to 69a2580 Compare December 14, 2022 16:34
@effigies effigies force-pushed the mnt/git-archive-support branch from 76c93a2 to 890f5de Compare December 14, 2022 16:43
@effigies
Copy link
Contributor Author

Getting bitten by pytest-dev/pytest#1596. Fortunately we're not trying to use the --dask option anywhere in CI, so just wrapping it up in a try/except.

Copy link
Collaborator

@ghisvail ghisvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sad for dask but looks like we are not the only one bitten by this issue.

@effigies effigies merged commit c2cc452 into nipype:master Dec 14, 2022
@effigies effigies deleted the mnt/git-archive-support branch December 14, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants