-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Add git-archive support for setuptools_scm #609
Conversation
f59e455
to
4da2504
Compare
Codecov ReportBase: 76.86% // Head: 80.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #609 +/- ##
==========================================
+ Coverage 76.86% 80.43% +3.56%
==========================================
Files 19 20 +1
Lines 4362 4391 +29
Branches 1260 0 -1260
==========================================
+ Hits 3353 3532 +179
- Misses 821 859 +38
+ Partials 188 0 -188
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4480da2
to
69a2580
Compare
76c93a2
to
890f5de
Compare
Getting bitten by pytest-dev/pytest#1596. Fortunately we're not trying to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Sad for dask
but looks like we are not the only one bitten by this issue.
Types of changes
Summary
Versioneer permitted
git archive
to store some limited version information in the artifacts, such as those generated by GitHub. setuptools_scm needs special prodding to do this.This adds and tests the feature. In the process, I've split the build and test stages from the main tests so that we can test different installation methods.
Checklist