Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor volume widget #43

Merged
merged 12 commits into from
Nov 14, 2018
Merged

Refactor volume widget #43

merged 12 commits into from
Nov 14, 2018

Conversation

janfreyberg
Copy link
Contributor

@janfreyberg janfreyberg commented May 20, 2018

I've made a new widget, VolumeWidget, which adds a bunch of new functionality to the volume widget that takes in nifti files, and misses some of the "custom plotting function" functionality of the NiftiWidget class.

This closes #26, #28, #30

For now I'd propose:

  • that this is the new recommended nii-file widget (i.e. the one described in the documentation first)
  • that the old functionality that wraps custom nilearn plotting functions stays under NiftiWidget
  • down the line, I'd like to re-factor NiftiWidget to look more like VolumeWidget, i.e. a class that implements traitlets / doesn't use widgets.interact. It would probably be renamed to CustomVolumeWidget or something along those lines.
  • eventually, I'd like to make all widgets (Surface, Streamlines) look more like this. I think it's a cleaner interface, and I think it will make it easier to be able to export them (eventually...)

To try it, take a look the demo notebook.

This doesn't use interact, so should be faster and a bit more
customisable
There were too many options in the dropdown, it's now restriced to just
a few (with the ability to add more).
- added a tickbox for guide lines
- added a tickbox to switch orientations
If an option is passed as a kwarg, it's fixed and no control element is
displayed.
@janfreyberg janfreyberg requested review from arokem and satra May 20, 2018 21:32
@janfreyberg
Copy link
Contributor Author

@cancan101 - please do share any thoughts on these changes. It would be particularly helpful if you could check if this addresses the issues you've had in the past. To install, simply clone this branch and install the development version with pip install -e repository/path

@janfreyberg janfreyberg merged commit 79b0bae into master Nov 14, 2018
@janfreyberg janfreyberg deleted the refactor-volume branch November 14, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to change axes direction to ImageJ standard
1 participant