BIAP: CoordinateImage API #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch culminates ~6 months of intermittent tinkering and revision of the concepts needed to support data sampled to surfaces. The particular use cases of CIFTI-2 and MNE's STC formats have driven a CoordinateAxis model that describes an axis that describes a sequence of sub-sampled surfaces and (raveled) volumes. Test implementations exist in another branch, but the target of this branch is simply to merge the BIAP to render in the docs. For posterity, here are the squashed commit messages: DOC: First pass at SurfaceImage BIAP DOC: Address suggestions DOC: Clarify use cases are motivating, not necessarily implementation target DOC: Small updates DOC: Update BIAP with a couple examples leading to further questions DOC: Separate Geometry and Header objects DOC: Smoothing example, typo ENH: First pass at surfaceimage template classes TEST: Build HDF5/Numpy-based surface classes DOC: Add VolumeGeometry stub DOC: Fix header formatting TEST: Example FreeSurfer subject (not fitting into class hierarchy) DOC: Add concatenable structure proposal ENH: Add structure collection API TEST: Rewrite FreeSurferSubject as GeometryCollection ENH: Possible VolumeGeometry STY: Geometry -> Pointset Rename SurfaceGeometry to TriangularMesh FIX: FreeSurfer example implementation ENH: Flesh out VolumeGeometry BIAP: Add SurfaceHeader.get_geometry() method Rename Geometry -> Pointset DOC: Commit current thinking on BIAP0009 RF: Remove test implementations for this branch
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 99 99
Lines 12217 12217
Branches 2391 2391
=======================================
Hits 11281 11281
Misses 612 612
Partials 324 324 Continue to review full report at Codecov.
|
|
Pre-test failures seem related to numpy/numpy#21052. |
Closes gh-1068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch culminates ~6 months of intermittent tinkering and revision of the concepts needed to support data sampled to surfaces. The particular use cases of CIFTI-2 and MNE's STC formats have driven a CoordinateAxis model that describes an axis that describes a sequence of sub-sampled surfaces and (raveled) volumes.
Test implementations exist in another branch, but the target of this branch is simply to merge the BIAP to render in the docs.