Support repeated extensions #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests will not pass until dependency lands first |
nipunn1313
force-pushed
the
repeated_extension
branch
from
f51572b to
b513e94
Compare
Generate RepeatedScalarFieldContainer and RepeatedCompositeFieldContainer for those fields.
nipunn1313
force-pushed
the
repeated_extension
branch
from
b513e94 to
802602e
Compare
|
Here's a relevant follow up for you @EPronovost. I'll probably land it soon, but would still appreciate eyes on it in case you catch something after the fact. Interestingly, this diff only adds tests to confirm the fix. The actual fix happened in #247 - which was a refactor that affected the extension generation. It relied on python/typeshed#5788 which landed and got into types-protobuf 3.17.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
Depends on
python/typeshed#5788
and gains some additional benefit from
python/typeshed#5787