-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate type-ignore that's generated for enums (allowing us to eliminate warn_unused_ignores = False in mypy.ini) #239
Comments
error: unused "type: ignore" comment Do you know a way for comments to only be used by |
nipunn1313
changed the title
Eliminate type-ignore that's generated for enums
Eliminate type-ignore that's generated for enums (allowing us to eliminate warn_unused_ignores = False in mypy.ini)
Jul 19, 2021
nipunn1313
added a commit
that referenced
this issue
Jul 22, 2021
nipunn1313
added a commit
that referenced
this issue
Jul 22, 2021
nipunn1313
added a commit
that referenced
this issue
Jul 22, 2021
nipunn1313
added a commit
that referenced
this issue
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per discussion in #214 - see if we can eliminate the type-ignore that's generated for enums
It exists to sidestep the circular dependency that our enum strategy creates. In order to use the alternate strategy of pulling the type definition up one level, we need type aliases to work within a class - see python/mypy#10788
The text was updated successfully, but these errors were encountered: