Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair 3dQwarp workflow #454

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Repair 3dQwarp workflow #454

wants to merge 15 commits into from

Conversation

psadil
Copy link
Contributor

@psadil psadil commented Jul 7, 2024

Closes #441

This repairs the 3dQwarp workflow. As before, 3dQwarp is used to generate a displacement field and correct the reference image.

As per discussion with @effigies during Brainhack 2024, the repairs were done so that the workflow now matches the topup workflow in terms of outputs and inputs. The repaired workflow now also returns an estimated fieldmap and the coefficients for a bspline fit to the fieldmap. Note that this means that the unwarped image returned in fmap_ref is in general not what one would get by reconstructing the fieldmap from fmap_coeff and unwarping the reference image in in_data.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.46%. Comparing base (08e198f) to head (dd5f251).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   76.40%   76.46%   +0.06%     
==========================================
  Files          32       32              
  Lines        2814     2830      +16     
  Branches      376      378       +2     
==========================================
+ Hits         2150     2164      +14     
- Misses        597      598       +1     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I had this collection of review comments queued up but didn't finish the review.

sdcflows/utils/epimanip.py Outdated Show resolved Hide resolved
sdcflows/utils/tests/test_epimanip.py Outdated Show resolved Hide resolved
sdcflows/workflows/fit/pepolar.py Show resolved Hide resolved
@@ -107,7 +107,7 @@ jobs:
pip install datalad datalad-osf
- name: Install fsl
run: |
conda install fsl-fugue fsl-topup
conda install fsl-fugue fsl-topup fsl-bet2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using BET anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@effigies effigies marked this pull request as draft October 4, 2024 19:18
@effigies
Copy link
Member

effigies commented Oct 4, 2024

@psadil Sorry about the long delay. I'm marking this as draft just so I know that it's waiting on you. Please feel free to mark as ready again whenever you get back to this.

@psadil
Copy link
Contributor Author

psadil commented Oct 4, 2024

@psadil Sorry about the long delay. I'm marking this as draft just so I know that it's waiting on you. Please feel free to mark as ready again whenever you get back to this.

Sorry it's taking me so long to respond to your review! I'm aiming to be able to get to this by the end of next week.

@psadil
Copy link
Contributor Author

psadil commented Oct 17, 2024

uh oh, seems like I may have messed things up with that force push?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init_3dQwarp_wf expects input that is missing from inputnode
2 participants