-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair 3dQwarp workflow #454
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
+ Coverage 76.40% 76.46% +0.06%
==========================================
Files 32 32
Lines 2814 2830 +16
Branches 376 378 +2
==========================================
+ Hits 2150 2164 +14
- Misses 597 598 +1
- Partials 67 68 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I had this collection of review comments queued up but didn't finish the review.
@@ -107,7 +107,7 @@ jobs: | |||
pip install datalad datalad-osf | |||
- name: Install fsl | |||
run: | | |||
conda install fsl-fugue fsl-topup | |||
conda install fsl-fugue fsl-topup fsl-bet2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using BET anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline still uses init_enhance_and_skullstrip_bold_wf, which depends on BET: https://github.com/nipreps/niworkflows/blob/1f9a0cf6d5b74e1aadf544841a0adaee19cc63b0/niworkflows/func/util.py#L391-L393
@psadil Sorry about the long delay. I'm marking this as draft just so I know that it's waiting on you. Please feel free to mark as ready again whenever you get back to this. |
Sorry it's taking me so long to respond to your review! I'm aiming to be able to get to this by the end of next week. |
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
uh oh, seems like I may have messed things up with that force push? |
Closes #441
This repairs the 3dQwarp workflow. As before,
3dQwarp
is used to generate a displacement field and correct the reference image.As per discussion with @effigies during Brainhack 2024, the repairs were done so that the workflow now matches the topup workflow in terms of outputs and inputs. The repaired workflow now also returns an estimated fieldmap and the coefficients for a bspline fit to the fieldmap. Note that this means that the unwarped image returned in
fmap_ref
is in general not what one would get by reconstructing the fieldmap fromfmap_coeff
and unwarping the reference image inin_data
.