Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhaseDiff SDC: phase1/phase2 implementation #15

Closed
oesteban opened this issue May 28, 2019 · 5 comments
Closed

PhaseDiff SDC: phase1/phase2 implementation #15

oesteban opened this issue May 28, 2019 · 5 comments
Milestone
1.0.0

Comments

@oesteban
Copy link
Member

oesteban commented May 28, 2019 •
edited
Loading

Based on the foundations set by nipreps/fmriprep#1359, finish up the phase1/2 implementation.
@oesteban
Copy link
Member Author

oesteban commented May 28, 2019 •
edited
Loading

Addresses nipreps/fmriprep#1169.

@oesteban oesteban transferred this issue from nipreps/fmriprep Jul 9, 2019
@mattcieslak
Copy link
Collaborator

#30 follows up on the suggestions in nipreps/fmriprep#1359 to switch to the official prelude approach instead of using arctan2. The end result is the same, but now the workflow is consistent with the documentation

oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 20, 2019
@oesteban
ENH: Large refactor of the orchestration workflow [wipe phdiff_*]
d76755c 
This PR:
  - [x] Refines the work in nipreps#53 addressing nipreps#40.
  - [x] Adds tests to cover the orchestration workflow.
  - [x] Fixes nipreps#7 (added regression tests for this bug).
  - [x] Updates the interface of phdiff workflows: removes the metadata
        input, which was defined for this workflow solely.
  - [x] Makes it trivial to extend the phdiff workflow to phase1/phase2
        workflows (nipreps#15).
@oesteban oesteban mentioned this issue Nov 20, 2019
Merged
5 tasks
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 20, 2019
@oesteban
ENH: Large refactor of the orchestration workflow [wipe phdiff_*]
279fce1 
This PR:
  - [x] Refines the work in nipreps#53 addressing nipreps#40.
  - [x] Adds tests to cover the orchestration workflow.
  - [x] Fixes nipreps#7 (added regression tests for this bug).
  - [x] Updates the interface of phdiff workflows: removes the metadata
        input, which was defined for this workflow solely.
  - [x] Makes it trivial to extend the phdiff workflow to phase1/phase2
        workflows (nipreps#15).
oesteban added a commit that referenced this issue Nov 23, 2019
@oesteban
ENH: Large refactor of the orchestration workflow [wipe phdiff_*]
18a1ef7 
This PR:
  - [x] Refines the work in #53 addressing #40.
  - [x] Adds tests to cover the orchestration workflow.
  - [x] Fixes #7 (added regression tests for this bug).
  - [x] Updates the interface of phdiff workflows: removes the metadata
        input, which was defined for this workflow solely.
  - [x] Makes it trivial to extend the phdiff workflow to phase1/phase2
        workflows (#15).
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 25, 2019
@oesteban
enh(phase1/2): base implementation
f13eeef 
Close nipreps#15.
@oesteban oesteban added this to the 1.0.0 milestone Nov 25, 2019
@soichih
Copy link

soichih commented Dec 23, 2019

@oesteban which version of fmriprep support phase1/2 type of fieldmap? I am testing it with 1.5.2 but it looks like it doesn't handle it (yet).

	 Found phase1/2 type of fieldmaps, which are not currently supported. fMRIPrep will discard them for susceptibility distortion correction. Please, follow up on this issue at https://github.com/poldracklab/fmriprep/issues/1655.
191223-13:56:29,758 nipype.workflow IMPORTANT:

@oesteban
Copy link
Member Author

We integrated the new fieldmaps in 1.5.3 - https://github.com/poldracklab/fmriprep/releases/tag/1.5.3

@soichih
Copy link

soichih commented Jan 3, 2020

I tried 1.5.3 (and 1.5.4) but I couldn't get it to work for us... nipreps/fmriprep#1921

I will stay with 1.5.2 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@mattcieslak @oesteban @soichih