Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add phase1/phase2 SDC support #1359
[ENH] Add phase1/phase2 SDC support #1359
Changes from all commits
b2a937a
f2b45d4
9dec5d8
840d167
bb510de
4d78483
6e0edda
9a0fcde
e5a6dee
d89c776
f6d4aa7
649dafe
8558aa5
1d12256
70b3413
191e155
880d04d
dc5b547
9f9284e
ce36514
0712c5e
4fd6add
09316a9
f9ca876
150b54f
ada0d9d
2c52d49
27c51ae
f57c063
2f6a294
a8fc3bd
0f7cdec
f2e861d
ff2d7d9
d94346f
5ce44ce
db42f74
6c7ec33
ef86939
1be1be1
c27d839
4d371a1
9c5b46b
85fcb4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there exists such a suffix in BIDS. This works because fmap_key gets renamed to phase1 either way (not sure about how then it digests the phase2 suffix, I'll check below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along the lines of the previous comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the difference map needs to be phase unwrapped? aren't the phase maps unwrapped individually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider:
p1 = pi - eps
p2 = -pi + eps
p1 - p2 = 2pi - 2eps = -2eps
Phase differences should be between -pi and pi, as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means you are clipping it again, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I think I misunderstood the context here. You're saying that
prelude
just does the clipping between -pi and pi, and we've already done that inphases2fmap
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understood before that each phase map needs to be unwrapped (which makes sense to me). If they are phase-unwrapped, there's no point on running PRELUDE (Phase Region Expanding Labeller for Unwrapping Discrete Estimates).
Also, I am very curious as to how the individual phase maps are unwrapped, if not done with PRELUDE. I know there are better methods out there (e.g., using graph cuts) but they are rarely used in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I have confirmed this point: as per the FUGUE guide, each phase map should be unwrapped with PRELUDE separately (step 3) of the guide. Then they can be subtracted as they are not wrapped within [-pi, pi) anymore.
After that point, the pipeline should be exactly the same as for the
phasediff
type of fieldmap.