Extend error reason in case of failed handshake #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maria-12648430
force-pushed
the
extend_handshake_failure_exit_reason
branch
from
12a470e
to
c50a115
Compare
|
About the pipeline failures in OTP 27: they happen because |
|
No it's erlang.mk, it'll work if you |
|
About the |
|
Added a test. Also made a change to obtain the peername early in the handshake, as it could happen that it is not available any more when an error happens. |
|
I have updated the CI, please force push to run CI again. |
juhlig
force-pushed
the
extend_handshake_failure_exit_reason
branch
from
d2babd6
to
956f5ab
Compare
juhlig
force-pushed
the
extend_handshake_failure_exit_reason
branch
from
956f5ab
to
fa138ab
Compare
|
Done. There is a failure in the shutdown suite (macOS, again 🙄) which seems to be a timing issue, in the test. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #336.