Proposal: http2 fallback to host header if authority is missing #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK with it but this needs tests and it'll need to use |
fredr
force-pushed
the
http2-authority-fallback
branch
from
d38e45c to
26869f7
Compare
|
Excellent! I've added a test to verify that we fallback on the host header. Do you want any other tests? Also, I didn't know if I should update the cowlib dep to point to mentioned pr? |
fredr
force-pushed
the
http2-authority-fallback
branch
from
26869f7 to
059dfd3
Compare
|
Hey @essen, any chanse this could be merged? or do you want me to make any changes? |
|
I'll get back to you when I come back to Cowboy in a few weeks. PR looks fine otherwise. |
|
Amended and merged, thanks! |
|
Thank you! 🍻 |
|
For anyone who is interested, this has now also been fixed in the kubernetes ingress: kubernetes/ingress-nginx#4212 |
|
Glad to hear, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the host header if
:authorityis not setWe use an nginx-ingress in kubernetes with the grpc-module. But for some reason the
:authorityheader is not forwarded (I'm digging into why), but the host header is.This causes cowlib and cowboy to reply with a protocol_error, and nginx will reply 502 Bad Gateway.
This was quite hard to debug, so even if you don't think cowboy/cowlib should handle this, this PR can act as some kind of documentation for others having the same problem.
Other http2 servers seems to fallback to use the host header if
:authoritywas not set.This one is dependent on ninenines/cowlib#73