[#580] Hide Compose androidx.compose.ui.tooling.PreviewActivity from the final release build #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luongvo
requested review from
AVI5HEK,
chornerman,
hoangnguyen92dn,
Johnsonmaung,
kaungkhantsoe,
manh-t,
minhnimble,
ryan-conway,
sleepylee,
thiennguyen0196 and
toby-thanathip
as code owners
Kover report for template-compose:🧛 Template - Compose Unit Tests Code Coverage:
|
| File | Coverage |
|---|
Modified Files Not Found In Coverage Report:
Dependencies.kt
build.gradle.kts
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
kaungkhantsoe
approved these changes
Aug 1, 2024
chornerman
approved these changes
Sep 3, 2024
eeeeaa
approved these changes
Oct 28, 2024
Johnsonmaung
approved these changes
Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#580
What happened 👀
Hide Compose
androidx.compose.ui.tooling.PreviewActivityfrom the final release build.Insight 📝
According to the latest update https://developer.android.com/develop/ui/compose/tooling:
ui-tooling-preview: Contains the API definitionsui-tooling: Contains the implementation and can be declared as debugImplementationProof Of Work 📹
No more
Activity (androidx.compose.ui.tooling.PreviewActivity) is not Protected. [android:exported=true]issue from the new VAPT report ✅