Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#500] The "Checkout" step in "bump_version" workflow does not need to set a custom token #532

Conversation

ryan-conway
Copy link
Collaborator

@ryan-conway ryan-conway commented Oct 6, 2023

closes #500

What happened 👀

  • Removed the token from Bump Version checkout step
  • Updated all Checkout calls for consistency

Insight 📝

We call the Checkout action on every workflow but the step name and version are inconsistent, so they have been updated in this PR too 👀

Proof Of Work 📹

Workflow run

Bump version PR

@ryan-conway ryan-conway self-assigned this Oct 6, 2023
@ryan-conway ryan-conway temporarily deployed to template-compose October 6, 2023 04:02 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: 34.25%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

bump_version.yml
bump_version.yml
deploy_staging_and_production_to_firebase_app_distribution.yml
draft-new-release.yml
publish_docs_to_wiki.yml
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
verify_newproject_script.yml

Codebase cunningly covered by count Shroud 🧛

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 62.05%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

bump_version.yml
bump_version.yml
deploy_staging_and_production_to_firebase_app_distribution.yml
draft-new-release.yml
publish_docs_to_wiki.yml
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
verify_newproject_script.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@ryan-conway ryan-conway merged commit cbfa993 into develop Oct 6, 2023
@ryan-conway ryan-conway deleted the chore/500-the-checkout-step-in-bump_version-workflow-does-not-need-to-set-a-custom-token branch October 6, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Checkout" step in "bump_version" workflow does not need to set a custom token
4 participants