[#502] Remove Bump version XML step from Bump version workflow #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-conway
temporarily deployed
to
template-compose
GitHub Actions
Inactive
Kover report for template-xml:🧛 Template - XML Unit Tests Code Coverage:
|
| File | Coverage |
|---|
Modified Files Not Found In Coverage Report:
bump_version.yml
Codebase cunningly covered by count Shroud 🧛
Kover report for template-compose:
🧛 Template - Compose Unit Tests Code Coverage: 62.05%
Coverage of Modified Files:
| File | Coverage |
|---|
Modified Files Not Found In Coverage Report:
bump_version.yml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
ryan-conway
requested review from
AVI5HEK,
chornerman,
doannimble,
hoangnguyen92dn,
kaungkhantsoe,
luongvo,
lydiasama,
manh-t,
minhnimble,
sleepylee,
thiennguyen0196,
toby-thanathip and
Wadeewee
as code owners
luongvo
approved these changes
Oct 6, 2023
| @@ -22,10 +22,6 @@ jobs: | |||
| run: | | |||
| perl -i -pe 's/^(templateScriptVersion=(.*))$/"templateScriptVersion=${{ github.event.inputs.newVersion }}"/e' version.properties | |||
|
|
|||
| - name: Bump version XML | |||
| run: | | |||
| perl -i -pe 's/ANDROID_VERSION_NAME =(.*)$/ANDROID_VERSION_NAME = "${{ github.event.inputs.newVersion }}"/g' sample-xml/buildSrc/src/main/java/Versions.kt | |||
There was a problem hiding this comment.
@ryan-conway Please feel free to fix this issue too #521 (new PR)
kaungkhantsoe
approved these changes
Oct 6, 2023
ryan-conway
deleted the
chore/502-remove-bump-version-xml-step-from-bump-version-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #502
What happened 👀
Bump version XMLfrombump_versionworkflowInsight 📝
The XML template is being deprecated so we should no longer bump the version on new iterations 🙏🏻
Proof Of Work 📹
Pull Request
Workflow run