[#228] Add TokenAuthenticator to template-xml

[kaungkhantsoe]

• Closes Add TokenAuthenticator setup #228

What happened 👀

Provide a description of the changes this pull request brings to the codebase. Additionally, when the pull request is still being worked on, a checklist of the planned changes is welcome to track progress.

Insight 📝

Describe in detail why this solution is the most appropriate, which solution you tried but did not go with, and how to test the changes. References to relevant documentation are welcome as well.

Proof Of Work 📹

Show us the implementation: screenshots, GIFs, etc.

[github-actions]

	9 Warnings
⚠️	Please add labels to this PR
⚠️	Uh oh! ApiServiceProvider.kt is under 95% coverage!
⚠️	Uh oh! ApplicationRequestAuthenticator.kt is under 95% coverage!
⚠️	Uh oh! AuthStatus.kt is under 95% coverage!
⚠️	Uh oh! AuthenticateResponse.kt is under 95% coverage!
⚠️	Uh oh! ResponseMapping.kt is under 95% coverage!
⚠️	Uh oh! SessionManagerImpl.kt is under 95% coverage!
⚠️	Uh oh! TokenRefresherImpl.kt is under 95% coverage!
⚠️	Uh oh! Your project is under 80% coverage!

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: 24.50%

Coverage of Modified Files:

File	Coverage
ApiServiceProvider.kt	0.00%
ApplicationRequestAuthenticator.kt	0.00%
AuthStatus.kt	0.00%
AuthenticateResponse.kt	0.00%
Error.kt	100.00%
ErrorResponse.kt	100.00%
ResponseMapping.kt	71.70%
SessionManagerImpl.kt	0.00%
TokenRefresherImpl.kt	0.00%

Modified Files Not Found In Coverage Report:

AuthModule.kt
AuthService.kt
Authenticate.kt
MockUtil.kt
OkHttpClientModule.kt
RetrofitModule.kt
SessionManager.kt
TokenRefresher.kt

Codebase cunningly covered by count Shroud 🧛

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 14.62%

Coverage of Modified Files:

File	Coverage
ApiServiceProvider.kt	0.00%
Error.kt	100.00%
ErrorResponse.kt	100.00%
ResponseMapping.kt	87.69%

Modified Files Not Found In Coverage Report:

ApplicationRequestAuthenticator.kt
AuthModule.kt
AuthService.kt
AuthStatus.kt
Authenticate.kt
AuthenticateResponse.kt
MockUtil.kt
OkHttpClientModule.kt
RetrofitModule.kt
SessionManager.kt
SessionManagerImpl.kt
TokenRefresher.kt
TokenRefresherImpl.kt

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

[toby-thanathip]

@luongvo @kaungkhantsoe I think let's postpone this for now, this issue is a lot bigger than I originally estimated.

It's best to create another issue first, to integrate a new API that works with a (refresh) token.

Because our current API doesn't have that. What do you think? 🙏

[ryan-conway]

It's best to create another issue first, to integrate a new API that works with a (refresh) token.

@Tuubz Do you mean to integrate an API into the template? It might be a better idea to add that to the sample projects instead (perhaps the survey API?) and keep only the authenticator stuff in the template, what do you think?

[toby-thanathip]

@ryan-conway Sorry for the late reply, but yes, you're correct. 👍

Please have a look at this thread: https://nimble-co.slack.com/archives/G41UCTGHL/p1614156128022800

IMO, I think we should go with GitHub API (convenient) or create a Mock API with Postman (flexible).

I'll create an RFC for this, what do you think? 🙏

[ryan-conway]

@Tuubz An RFC sounds like a good idea 😄

[toby-thanathip]

@ryan-conway @kaungkhantsoe RFC created: #434 🚀