Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to working fork of ncurses wrapper #1670

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Conversation

Patasuss
Copy link
Contributor

The original version has an out of date .nimble file which does not work with the current version of nimble.
See this issue in the original repo. Someone made a PR with a fix, but the maintainer seems inactive.

I forked the repo, fixed the .nimble file and corrected a compiler error within ncurses.nim.

The [original version](https://github.com/rnowley/nim-ncurses/) has an out of date .nimble file which does not work with the current version of nimble.
See [this issue] in the original repo. Someone made a [PR](rnowley/nim-ncurses#25) with a fix, but the maintainer seems inactive.

I forked the repo, fixed the .nimble file and corrected a compiler error within ncurses.nim.
@Patasuss Patasuss changed the title Changed to working fork of ncurses wrapper Move to working fork of ncurses wrapper Oct 14, 2020
@narimiran
Copy link
Member

narimiran commented Oct 15, 2020

Someone made a PR with a fix, but the maintainer seems inactive.

I'm surprised to see that the changes in that PR are needed, because the existing version seems to follow what is written here: https://github.com/nim-lang/nimble#creating-packages

@genotrance @dom96 any idea why the original package and its .nimble file doesn't work? Is the problem in name parameter?

@Patasuss
Copy link
Contributor Author

Patasuss commented Oct 15, 2020

This is the error log I get:

madpat example> nim --version
Nim Compiler Version 1.3.7 [Linux: amd64]
Compiled at 2020-10-15
Copyright (c) 2006-2020 by Andreas Rumpf

git hash: 1bbc20010e3c8efc0de2c73a8d0d3d844de97049
active boot switches: -d:release -d:nativeStackTrace

madpat nim-ncurses> nimble --version
nimble v0.12.0 compiled at 2020-10-15 07:47:11
git hash: 8f7af860c5ce9634af880a7081c6435e1f2a5148
madpat nim-ncurses> nimble install
     Error: Could not read package info file in /home/madpat/tmp/nim/nim-ncurses/ncurses.nimble;
        ...   Reading as ini file failed with: 
        ...     Invalid section: .
        ...   Evaluating as NimScript file failed with: 
        ...     /home/madpat/tmp/nim/nim-ncurses/ncurses.nimble(2, 1) Error: undeclared identifier: 'name'
        ... printPkgInfo() failed.

@genotrance
Copy link
Contributor

Nimble files have never supported the name field - it has been called packageName for at least 5 years and is not required since it is derived from the name of the nimble file.

@narimiran narimiran closed this Oct 15, 2020
@narimiran narimiran reopened this Oct 15, 2020
Since Moe is an active project (also featured on nimble.directory), it would be a good idea to make the nim-ncurses version it uses the standard one.
@Patasuss
Copy link
Contributor Author

Are there any problems with this PR that I should know of? It's just sitting here, inactive.

@narimiran narimiran merged commit 5618897 into nim-lang:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants