Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate tagged versions upfront #1289

Merged
merged 10 commits into from
Nov 25, 2024
Prev Previous commit
Next Next commit
Dont traverse additional versions when the dep is fixed
jmgomez committed Nov 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 1ea84c977af2bab63ca00424a17a50250946e525
2 changes: 1 addition & 1 deletion src/nimblepkg/nimblesat.nim
Original file line number Diff line number Diff line change
@@ -470,7 +470,7 @@ proc getPackageMinimalVersionsFromRepo*(repoDir, pkgName: string, downloadMethod
proc downloadMinimalPackage*(pv: PkgTuple, options: Options): seq[PackageMinimalInfo] =
if pv.name == "": return newSeq[PackageMinimalInfo]()
if pv.isNim and not options.disableNimBinaries: return getAllNimReleases(options)
if pv.ver.kind == verSpecial:
if pv.ver.kind in [verSpecial, verEq]: #if special or equal, we dont retrieve more versions as we only need one.
result = @[downloadPkInfoForPv(pv, options).getMinimalInfo(options)]
else:
let (downloadRes, downloadMeth) = downloadPkgFromUrl(pv, options)