+ added command line option --clientProcessId=XXX that allows the server to
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver to
monitor the client process ID even before the initialize request arrives. This
is a recommendation in the LSP spec:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#implementationConsiderations
In case the command line option and the initialize request specify different
process IDs, we monitor both client process IDs, but we also write a debug log
message, because this is a violation of the LSP spec on behalf of the LSP
client, so it's not perfectly clear what the server behaviour should be in
this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monitor the client process ID even before the initialize request arrives. This
is a recommendation in the LSP spec:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#implementationConsiderations
In case the command line option and the initialize request specify different
process IDs, we monitor both client process IDs, but we also write a debug log
message, because this is a violation of the LSP spec on behalf of the LSP
client, so it's not perfectly clear what the server behaviour should be in
this case.