Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] remove xmldom and xmldomparser #9234

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Conversation

narimiran
Copy link
Member

As discussed in #8238:

We can remove xmldom and xmldomparser, it precedes xmltree/xmlparser and is replaced by those modules. AFAIK nobody really uses them anyway.

@dom96
Copy link
Contributor

dom96 commented Oct 7, 2018

Might be nice to create a Nimble packages for the few that use this module :)

@kaushalmodi
Copy link
Contributor

@dom96 But who will take the ownership of those? Shouldn't the original author of those create the nimble packages?

@kaushalmodi
Copy link
Contributor

@dom96 umm. OK. So you are the original author of those. :P

@kaushalmodi
Copy link
Contributor

kaushalmodi commented Oct 9, 2018

Speaking from my experience with Emacs project, should Nim create an "obsolete" repo? Packages obsoleted in stdlib can be moved to that repo as nimble packages. That way no one has to take up the ownership responsibility.

If someone wants to take up the responsibility, they can claim it, and then only the URL in the nimble packages json needs to change.

Ref: Emacs lisp/obsolete

@kaushalmodi
Copy link
Contributor

kaushalmodi commented Oct 9, 2018

So a question .. looks like there's some agreement about obsolete packages. Let's say the repo is named "obsolete-packages", and its URL is https://github.com/nim-lang/obsolete-packages.

Then within that repo, we will have:

./
├── obsolete-pkg1/
│  ├ ..
│  └── obsolete-pkg1.nimble
└── obsolete-pkg2/
   ├ ..
   └── obsolete-pkg2.nimble

So, can we have Nimble packages be pointed to different subdirs from the same repo? @dom96?

@Araq
Copy link
Member

Araq commented Oct 9, 2018

@kaushalmodi yeah I know for certain that Nimble supports that.

kaushalmodi added a commit to kaushalmodi-forks/graveyard that referenced this pull request Oct 9, 2018
@kaushalmodi
Copy link
Contributor

I know for certain that Nimble supports that.

Got it: https://github.com/nim-lang/nimble#package-urls

@Araq
Copy link
Member

Araq commented Oct 9, 2018

Btw web/website.ini is dead and should be removed.

@Araq Araq merged commit 27e4825 into nim-lang:devel Oct 9, 2018
@timotheecour timotheecour mentioned this pull request Oct 10, 2018
@narimiran narimiran deleted the xml-cleanup branch October 14, 2018 09:26
krux02 pushed a commit to krux02/Nim that referenced this pull request Oct 15, 2018
narimiran added a commit to narimiran/Nim that referenced this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants