Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix #19743; db_sqlite.tryInsertID does raise exceptions in 1.6.0 [backport: 1.6]" #19745

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Revert "fix #19743; db_sqlite.tryInsertID does raise exceptions in 1.6.0 [backport: 1.6]" #19745

merged 1 commit into from
Apr 25, 2022

Conversation

Araq
Copy link
Member

@Araq Araq commented Apr 25, 2022

Reverts #19744

@Araq
Copy link
Member Author

Araq commented Apr 25, 2022

It's most silly that tryInsert cannot raise. If the SQL is illformed, it can raise. The try in the name is about reporting missing data, not about illformed SQL.

@ringabout
Copy link
Member

It seems

Nim/lib/impure/db_odbc.nim

Line 251 in b10f0e7

except: discard
has the same problem.

@ringabout ringabout mentioned this pull request Apr 25, 2022
Merged
@Araq Araq merged commit ee0a470 into devel Apr 25, 2022
@Araq Araq deleted the revert-19744-pr_sqlite branch April 25, 2022 09:59
@ringabout ringabout mentioned this pull request Apr 25, 2022
Open
ringabout pushed a commit that referenced this pull request Dec 1, 2022
@Araq @ringabout
Revert "fix db_sqlite.tryInsertID does raise exceptions in 1.6.0 #197…
14c6c1c 
…43 (#19744)" (#19745)

This reverts commit b10f0e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araq @ringabout