Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close #5540 generic object with generic field evaluated too early #18062

Merged
merged 2 commits into from
May 23, 2021
Merged

close #5540 generic object with generic field evaluated too early #18062

merged 2 commits into from
May 23, 2021

Conversation

timotheecour
Copy link
Member

close #5540

@timotheecour timotheecour mentioned this pull request May 23, 2021
Closed
@timotheecour timotheecour added the Ready For Review (please take another look): ready for next review round label May 23, 2021
ringabout
ringabout reviewed May 23, 2021
View reviewed changes
tests/misc/t5540.nim Outdated Show resolved Hide resolved
ringabout
ringabout reviewed May 23, 2021
View reviewed changes
tests/misc/t5540.nim Outdated Show resolved Hide resolved
@timotheecour timotheecour merged commit 1636c05 into nim-lang:devel May 23, 2021
@timotheecour timotheecour deleted the pr_close_5540_generic_field branch May 23, 2021 08:02
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
@timotheecour @PMunch
close nim-lang#5540 generic object with generic field evaluated too e…
9675164 
…arly (nim-lang#18062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringabout ringabout ringabout approved these changes

Assignees
No one assigned
Labels
Ready For Review (please take another look): ready for next review round
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generic object with generic field evaluated too early
2 participants
@timotheecour @ringabout