Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: testament r filename (etc) fails (pcat still works) #17859

Closed
timotheecour opened this issue Apr 26, 2021 · 1 comment · Fixed by #17862
Closed

regression: testament r filename (etc) fails (pcat still works) #17859

timotheecour opened this issue Apr 26, 2021 · 1 comment · Fixed by #17862

Comments

@timotheecour
Copy link
Member

timotheecour commented Apr 26, 2021

regression introduced in #16698 /cc @xflywind

Example

nim r testament/testament.nim r tests/errmsgs/undeclared_routime4.nim

Current Output

FAIL: tests/errmsgs/undeclared_routime4.nim c
Test "tests/errmsgs/undeclared_routime4.nim" in category "errmsgs"
Failure: reMsgsDiffer
Expected:
undeclared_routime4.nim(10, 10) Error: undeclared field: 'bar'


Gotten:
undeclared_routime4.nim(10, 10) Error: undeclared field: 'bar' for type undeclared_routime4.Foo [type declared in undeclared_routime4.nim(8, 6)]

Expected Output

works

Additional Information

1.5.1 01bca8c
nim r testament/testament.nim pcat errmsgs still works (that's what's tested in CI, but r instead of pcat is uesful during development allowing to test 1 specific test and should keep working)

#16698 was a good PR but it needs an adjustment to handle this correctly

#17861 also sheds some explanation on this: the test files started with u, not t, so were never run in CI, which probably explains why pcat works but not r; nevertheless, this is a (hopefully easily fixable) regression that is probably specific to only those files tests/errmsgs/[^t]*.nim

@timotheecour
Copy link
Member Author

=> #17862

Araq pushed a commit that referenced this issue Apr 27, 2021
…nim check (#17862)

* rename a test so it runs in CI; merge several tests with nim check

* continue

* continue

* continue

* rename tests/errmsgs/undeclared_routine_compiles.nim -> tests/errmsgs/tundeclared_routine_compiles.nim
PMunch pushed a commit to PMunch/Nim that referenced this issue Mar 28, 2022
…ts with nim check (nim-lang#17862)

* rename a test so it runs in CI; merge several tests with nim check

* continue

* continue

* continue

* rename tests/errmsgs/undeclared_routine_compiles.nim -> tests/errmsgs/tundeclared_routine_compiles.nim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant