Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc testament issues #16521

Open
8 of 14 tasks
timotheecour opened this issue Dec 30, 2020 · 0 comments
Open
8 of 14 tasks

misc testament issues #16521

timotheecour opened this issue Dec 30, 2020 · 0 comments

Comments

@timotheecour
Copy link
Member

timotheecour commented Dec 30, 2020

  • Bug 1
    tests/manyloc/standalone/barebone.nim specifies output in spec but output is wrong and never checked, because testament hardcodes test.spec.action = actionCompile
    => refs #16521 include=>import fatal.nim; add tstandalone #16522

  • Bug 2
    tests/manyloc/ is bad, it should use testament spec to pass flags (eg: matrix) instead of relying on nim.cfg eg barebone.nim.cfg

  • Bug 3
    instead of findMainFile in tests/manyloc/, it should use txxx.nim convention

  • Bug 4
    include "$projectpath/panicoverride" in fatal.nim is just... bad; there are better ways to write tests without changing stdlib
    => refs #16521 include=>import fatal.nim; add tstandalone #16522

  • Bug 5
    seems buggy: p.next called for pcat but not for cat in testament.nim despite this

Currently the only difference is that we don't want to run joinable tests

=> #16577

  • Bug 7
    instead of PASS: tests/misc/tdefine.nim c (which doesn't show matrix flags etc), show the cmd actually used

  • Bug 8
    --megatest:off is ignored with pcat:
    XDG_CONFIG_HOME= nim r testament/testament.nim --megatest:off pcat foo
    still shows:
    JOINED: tests/foo/tbar.nim c

  • Bug 9
    runnableExamples failures have bad formatting, hard to see:
    [runnableExamples] failed: generated file: '/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_group0_examples.nim' group: '(rdoccmd: "", docCmd: "", code: "# autogenerated by docgen\n# source: /Users/timothee/git_clone/nim/fusion/src/fusion/js/jsxmlserializer.nim\n# rdoccmd: \nimport r"/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_examples1.nim"\n", index: 0)' cmd: /Users/timothee/git_clone/nim/Nim_devel/bin/nim js -r --lib:/Users/timothee/git_clone/nim/Nim_devel/lib --warning:UnusedImport:off --path:/Users/timothee/git_clone/nim/fusion --nimcache:/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples /Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_group0_examples.nim
    => improve formatting of error message when runnableExamples fails #16677

  • Bug 10
    nimout incorrectly includes program output when used in combination with cmd + -r => now reported in testament: cmd: "nim c -r $file" will execute code twice and cause nimout to include program output #16701

  • Bug 11
    specs tfile, tline, tcolumn are unused, undocumented(?) and redundant, should be removed

  • Bug 12
    matrix doesn't work with action: "reject"
    => fix #17960: honor matrix also for action: compile, action: reject #17980

  • Bug 13 refs fix #15617(fix compilation failure on -d:useMalloc --gc:none) #17555 (comment)

Since testament specializes the "gc" directory, this test is never run. --> We need to tweak testament for category "gc" in order to prevent this from happening the next time.

Additional Information

devel 1.5.1 b42e7c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant