You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug 7
instead of PASS: tests/misc/tdefine.nim c (which doesn't show matrix flags etc), show the cmd actually used
Bug 8 --megatest:off is ignored with pcat: XDG_CONFIG_HOME= nim r testament/testament.nim --megatest:off pcat foo
still shows:
JOINED: tests/foo/tbar.nim c
Bug 9
runnableExamples failures have bad formatting, hard to see:
[runnableExamples] failed: generated file: '/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_group0_examples.nim' group: '(rdoccmd: "", docCmd: "", code: "# autogenerated by docgen\n# source: /Users/timothee/git_clone/nim/fusion/src/fusion/js/jsxmlserializer.nim\n# rdoccmd: \nimport r"/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_examples1.nim"\n", index: 0)' cmd: /Users/timothee/git_clone/nim/Nim_devel/bin/nim js -r --lib:/Users/timothee/git_clone/nim/Nim_devel/lib --warning:UnusedImport:off --path:/Users/timothee/git_clone/nim/fusion --nimcache:/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples /Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_group0_examples.nim
=> improve formatting of error message when runnableExamples fails #16677
Since testament specializes the "gc" directory, this test is never run. --> We need to tweak testament for category "gc" in order to prevent this from happening the next time.
Bug 1
tests/manyloc/standalone/barebone.nim specifies output in spec but output is wrong and never checked, because testament hardcodes
test.spec.action = actionCompile
=> refs #16521 include=>import fatal.nim; add tstandalone #16522
Bug 2
tests/manyloc/ is bad, it should use testament spec to pass flags (eg: matrix) instead of relying on nim.cfg eg
barebone.nim.cfg
Bug 3
instead of
findMainFile
in tests/manyloc/, it should usetxxx.nim
conventionBug 4
include "$projectpath/panicoverride"
in fatal.nim is just... bad; there are better ways to write tests without changing stdlib=> refs #16521 include=>import fatal.nim; add tstandalone #16522
Bug 5
seems buggy:
p.next
called for pcat but not for cat in testament.nim despite thiswhiteListedDirs: add
htmldocs
andpkgs
(because regression(1.4.2=>devel):nim c main
createspkgs
dir in current directory #16556 can have created pkgs even if bug was fixed in devel)=> #16577
Bug 7
instead of
PASS: tests/misc/tdefine.nim c
(which doesn't show matrix flags etc), show the cmd actually usedBug 8
--megatest:off
is ignored withpcat
:XDG_CONFIG_HOME= nim r testament/testament.nim --megatest:off pcat foo
still shows:
JOINED: tests/foo/tbar.nim c
Bug 9
runnableExamples failures have bad formatting, hard to see:
[runnableExamples] failed: generated file: '/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_group0_examples.nim' group: '(rdoccmd: "", docCmd: "", code: "# autogenerated by docgen\n# source: /Users/timothee/git_clone/nim/fusion/src/fusion/js/jsxmlserializer.nim\n# rdoccmd: \nimport r"/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_examples1.nim"\n", index: 0)' cmd: /Users/timothee/git_clone/nim/Nim_devel/bin/nim js -r --lib:/Users/timothee/git_clone/nim/Nim_devel/lib --warning:UnusedImport:off --path:/Users/timothee/git_clone/nim/fusion --nimcache:/Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples /Users/timothee/git_clone/nim/fusion/nimcache/runnableExamples/jsxmlserializer_group0_examples.nim
=> improve formatting of error message when runnableExamples fails #16677
Bug 10
nimout
incorrectly includes program output when used in combination withcmd
+-r
=> now reported in testament:cmd: "nim c -r $file"
will execute code twice and causenimout
to include program output #16701Bug 11
specs tfile, tline, tcolumn are unused, undocumented(?) and redundant, should be removed
Bug 12
matrix
doesn't work withaction: "reject"
=> fix #17960: honor
matrix
also foraction: compile, action: reject
#17980Bug 13 refs fix #15617(fix compilation failure on -d:useMalloc --gc:none) #17555 (comment)
files in
tests/
not starting witht
should be checked against a whitelist to ensure bugs like mentioned here don't happen: fix #17859; rename tests so they run in CI; merge several tests with nim check #17862Additional Information
devel 1.5.1 b42e7c0
The text was updated successfully, but these errors were encountered: