use type symbol position field instead

compiler/ast.nim

@@ -920,8 +920,9 @@ type
                               # for modules, an unique index corresponding
                               # to the module's fileIdx
                               # for variables a slot index for the evaluator
-                              # for routines the minimum required parameters
-                              # (could be part of the type but no space there)
+                              # for routine type symbols the minimum required
+                              # parameters (could be part of the type but no
+                              # space for an integer there)
     offset*: int              # offset of record field
     loc*: TLoc
     annex*: PLib              # additional fields (seldom used, so we use a

compiler/semtypes.nim

@@ -1405,12 +1405,11 @@ proc semProcTypeNode(c: PContext, n, genericParams: PNode,
       onDef(a[j].info, arg)
       a[j] = newSymNode(arg)
 
-  if not isType:
-    # routine symbol for which the params are being checked
-    let s = result.owner
-    if s != nil:
-      # set the position field to the minimum number of required parameters
-      s.position = requiredCount
+  # generate sym for routine type to set position field to
+  if result.sym == nil:
+    result.sym = symFromType(c, result, n.info)
+  # set the position field to the minimum number of required parameters
+  result.sym.position = requiredCount
 
   var r: PType
   if n[0].kind != nkEmpty:

compiler/sigmatch.nim

@@ -2447,11 +2447,11 @@ proc matchesAux(c: PContext, n, nOrig: PNode, m: var TCandidate, marker: var Int
       noEagerParamCountMatch notin c.config.legacyFeatures and
       (when defined(nimsuggest): c.config.ideCmd notin {ideSug, ideCon} else: true):
     # routine symbols precalculate minimum argument count in `position` field
-    # if there is no routine symbol, don't bother calculating
-    if m.callee.kind == tyProc and m.calleeSym != nil and
-        m.calleeSym.kind in skProcKinds:
+    # of type symbol
+    # if there is no routine type symbol, don't bother calculating
+    if m.callee.kind == tyProc and m.callee.sym != nil:
       # if this is unset, it's 0 by default, which matches everything anyway:
-      let minCount = m.calleeSym.position
+      let minCount = m.callee.sym.position
       if givenCount < minCount:
         m.firstMismatch.kind = kMissingParam
         a = givenCount + 1

tests/template/toverloadeduntypedparam.nim

@@ -87,21 +87,3 @@ block:
   fun2(true, nonexistant) # ok
   fun2(1, nonexistant) # ok
   discard fun2(nonexistant)
-
-block: # make sure using position field is compatible
-  template code: untyped =
-    type Foo = object
-      x, y, z: int
-      p: proc ()
-    let a = 1
-    let b = 2
-    let c = 3
-    let p = proc() = discard
-    p()
-    let foo = Foo(x: a, y: b, z: c, p: p)
-    foo.p()
-    proc bar(x, y, z: int, p: proc()) =
-      p()
-    bar(a, b, c, p)
-  static: code()
-  code()