Route summary reporting error fixed #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You did not mention this is for GSoC, see #67 . We can open it again once we get to this point. |
|
Now that we have some guidelines, I'll open this again. https://github.com/gis-ops/valhalla-app/wiki/GSoC-2023 |
|
I'd just ask you to revert the tileset age thing and focus on just one issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the code for formatDuration function defined in Summary.jsx to be same as the one defined in Map.jsx. As the definition in Map.jsx seemed more appropriate. Do let me know if any modifications are required.
Update: Also did the enhancement as required of showing the user the tileset age. Do let me know if any modifications are required.