Height-graph width reduced

[MihirKp25]

🛠️ Fixes Issue

Closes #136

👨‍💻 Changes proposed

I have reduced the width of height graph from 0.9 to 0.75 in Map.jsx file. I tried to change this width dynamically but it didn't end well. But still it looks pretty nice to me and now we can easily see y axis of height graph.

📄 Note to reviewers

If you find a way of reducing the width dynamically whenever the direction tab closes please tell me :)

📷 Screenshots

[chrstnbwnkl]

@MihirKp25 could you please resolve existing conflicts so we can have a look at your PR?

[MihirKp25]

I have resolved conflicts. Sorry for inconvenience.

[nilsnolde]

The whitespace-only changes seem irrelevant, I’d actually expect prettier to complain.. Can you revert those?

[MihirKp25]

I have made your suggested changes @nilsnolde

[chrstnbwnkl]

please check your PR again for unnecessary, whitespace-only changes.

[MihirKp25]

Sorry I misinterpreted the last change request and added spaces in this file. I removed those changes. Please let me know if there are any other unnecessary changes I have made. And sorry for the inconvenience.

[nilsnolde]

Fine for me, thanks. I'll let @chrstnbwnkl merge if he's ok with this.

[chrstnbwnkl]

In order for the graph to resize based on the panel's collapsed state, this should not only execute in componentDidMount (which only runs once), but whenever the side panel's collapsed state changes.

[MihirKp25]

I will try to make your suggested changes asap.

[MihirKp25]

osm.-.Made.with.Clipchamp_1680012651071.mp4

@chrstnbwnkl I have made changes in the function such that the width of the height graph container reduces as the button is clicked. But it seems svg does not have automatic fit content like HTML tags. Can you help me with this error? I have actually used the query selector method to change the width of the container.

[chrstnbwnkl]

@MihirKp25 can you push your latest changes? The functionality in the video looks pretty close to what we want to achieve, right?

[MihirKp25]

Changes are pushed @chrstnbwnkl . Also, I want to contact you for review of my GSOC proposal. Can you tell me how can I do this

[nilsnolde]

This looks pretty good, thanks @MihirKp25 !

You can find more info on the proposal here: https://wiki.openstreetmap.org/wiki/Google_Summer_of_Code/2023 and here: #67. If you follow those guidelines you should be good. We have (un)fortunately too many applicants to do extensive proposal review. I suggest you upload it to GSoC, we'll surely read and consider it.