Merge origin fork. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md. Querystring libraries note * Typo in README.md Co-Authored-By: airs0urce <[email protected]> * Update README.md Co-Authored-By: airs0urce <[email protected]>
It seems that `responseType: 'blob'` doesn't actually work in Node (when I tried using it, response.data was a string, not a Blob, since Node doesn't have Blobs), so this clarifies that this option should only be used in the browser
- issue link is not found. - typo: issue => issues
… (#2391) * Adding tests to show config.url mutation Because config.url is modified while processing the request when the baseURL is set, it is impossible to perform a retry with the provided config object. Ref #1628 * Fixing url combining without modifying config.url As config.url is not modified anymore during the request processing. The request can safely be retried after it failed with the provided config. resolves #1628
* Fix #2234 * added spacing --eslint * added test cases * removed unexpected cases after updating the code
…est (#2383) Inside Axios.prototype.request function, It's forced to set method to 'get' after `mergeConfig` if config.method exists, which makes the defaults.method not effective.
* README.md COOKBOOK.md: minor fixes * simplify language * ECOSYSTEM: create a few categories * Examples: log port listening to * upgrade bootstrap 3 -> 4 in examples bootstrap 4 is slightly smaller then 3.2.0 so it should also help load examples faster * categorize 0.19 items a little differently surface user/consumer changes first
made the license section link up to the respective file.
This badge will show the version on CDNJS! Co-authored-by: Jay <[email protected]>
Co-authored-by: Jay <[email protected]>
* Failing test for #1252 * Only delete header keys that match an HTTP verb if the value is a non-string Co-authored-by: David Ko <[email protected]> Co-authored-by: Jay <[email protected]>
There is a bug in react native Android platform when using get method. It will trigger a 'Network Error' when passing the requestData which is an empty string to request.send function. So if the requestData is an empty string we can set it to null as well to fix the bug. Co-authored-by: Jay <[email protected]>
…ion (#1492) * Fixing password encoding with special characters in basic authentication * Adding test to check if password with non-Latin1 characters pass Co-authored-by: petr.mares <[email protected]> Co-authored-by: Jay <[email protected]>
* removing @ character from replacement list since it is a reserved character * Updating buildURL test to not include the @ character * Removing console logs Co-authored-by: Jay <[email protected]>
* Fixing default transformRequest of TypedArrays with buffer pools A buffer pool is a large ArrayBuffer of a preset size used with a TypedArray such as Uint8Array. This can speed up performance when constructing TypedArrays of unknown sizes, and is a technique used by Node with their Buffers, and by libraries like dcodeIO/protobuf.js. Because the ArrayBuffer of such a TypedArray is much longer than the array itself, using `.buffer` to transform the array before POSTing results in sending a request with many extraneous empty bytes, which is wastefule and may result in unexpected behavior. Using `.slice()` before grabbing the ArrayBuffer fixes the problem by creating a new TypedArray with a buffer of the expected length. Signed-off-by: Zac Delventhal <[email protected]> * Adding test for using default transformRequest with buffer pools Adds a new test to the default transformRequest, running it on a Uint8Array with a byte length of 16, but a much larger ArrayBuffer with a byte length of 256. The transformed array should not include any extra bytes, and so must have a byte length of just 16. Signed-off-by: Zac Delventhal <[email protected]> Co-authored-by: Zac Delventhal <[email protected]> Co-authored-by: Jay <[email protected]>
Co-authored-by: Jay <[email protected]>
…2773) Co-authored-by: Xianming Zhong <[email protected]> Co-authored-by: Jay <[email protected]>
Small change to the data attribute doc of the config. A request body can also be set for DELETE methods but this wasn't mentioned in the documentation (it only mentioned POST, PUT and PATCH). Took my some 10-20 minutes until I realized that I don't need to manipulate the request body with transformRequest in the case of DELETE. Co-authored-by: Jay <[email protected]>
* Updating Readme.md - remove axios.all(), axios.spread() * Updating Readme.md - replace example - axios.all() -> Promise.all() - axios.spread(function (acct, perms)) -> function (acct, perms) - add deprecated mark * Update README.md Make changes after review Co-authored-by: Jay <[email protected]>
Co-authored-by: Jay <[email protected]>
Co-authored-by: Emily Morehouse <[email protected]> Co-authored-by: Jay <[email protected]>
Co-authored-by: Jay <[email protected]>
* docs(): Detailed config options environment. * Update README.md Co-authored-by: Jay <[email protected]>
* Adding console log on sandbox server startup * Update server.js Add server error handeling * Update server.js Better error message, remove retry. Co-authored-by: Philippe Recto <[email protected]> Co-authored-by: Felipe Martins <[email protected]> Co-authored-by: Jay <[email protected]>
* test with Node.js 12 * test with latest Co-authored-by: Jay <[email protected]>
Co-authored-by: Jay <[email protected]>
* Adding failing test * Fixing #2587 default custom config persisting * Adding Concat keys and filter duplicates * Fixed value from CPE * update for review feedbacks * no deepMerge * only merge between plain objects * fix rename * always merge config by mergeConfig * extract function mergeDeepProperties * refactor mergeConfig with all keys, and add special logic for validateStatus * add test for resetting headers * add lots of tests and fix a bug * should not inherit `data` * use simple toString * revert #1845 Co-authored-by: David Tanner <[email protected]> Co-authored-by: Justin Beckwith <[email protected]>
* add close actions * fix with checkout * update issue templates * add reminder * update close message
* prepare stale actions * update messages * Add exempt labels and lighten up comments Co-authored-by: Jay <[email protected]>
* Update close-issues.yml Update close message to read better 😄 * Fix use of quotations Use single quotes as per other .yml files * Remove user name form message
* fix stale bot config * fix multiple lines
* add toc (preview) * remove toc in toc Signed-off-by: Moni <[email protected]> * fix sublinks * fix indentation * remove redundant table links * update caps and indent * remove axios Co-authored-by: Moni <[email protected]> Co-authored-by: Jay <[email protected]>
* Adding support for URLSearchParams in node * Remove un-needed code * Update utils.js * Make changes as suggested Co-authored-by: Kamil Posiadala <[email protected]> Co-authored-by: Jay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.