feat: add option to reject when image loading error has occurred. #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
related to #2424
The original bug is: Safari (iOS/Mac) fail to write image to canvas sometimes.
However, I had no idea to fix this bug. And I found that when I re-called html2canvas, then image was displayed correctly.
So I want to know the output was failed or not, as reject of the promise.
Test plan (required)
Sorry, I had no good idea for the test.
But this commit is not breaking any test.
Code formatting
Please make sure that code adheres to the project code formatting. Running
npm run formatwill automatically format your code correctly.