Added filter support. Added color space conversion. #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Prindl any updates to this? |
It is not necessary.
|
I would love to see this PR merged. Any updates ? |
|
Could someone resolve this conflicts and merge????? |
|
Can I request at least add basic support grayscale filter? |
|
I think this'll need a rewrite. The library has been refactored into Typescript since this was authored and its likely the flow has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic support for the following filters:
brightness
contrast
grayscale
hue-rotate
invert(incomplete)
opacity
saturate
sepia
Single filters work quite well overall.
Combining several filters still needs some improvement.
The idea is to draw the image on the canvas and then redraw it with the filters applied.
However, getImageData() gets all the pixels in the area, which means if border-radius has a value, the filters will also apply on the background there.