Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image with loading attribute as "lazy" not shown in Firefox #2312

Closed
frandemona opened this issue Aug 5, 2020 · 2 comments · Fixed by #2314
Closed

Image with loading attribute as "lazy" not shown in Firefox #2312

frandemona opened this issue Aug 5, 2020 · 2 comments · Fixed by #2314
Labels
Bug

Comments

@frandemona
Copy link

frandemona commented Aug 5, 2020 •
edited
Loading

Bug reports:

I've been trying to get images to show on Firefox and found out that if the img has a loading attribute with lazy it will not show in the canvas as shown in this jsfiddle.

It's not a problem of the library per se, just wanted to explain it here for anyone who has been having the same problem as us, because I suppose lots of developers will be adding this new attribute for optimization of their sites :)

Specifications:

  • html2canvas version tested with: vtest2
  • Browser & version: Firefox 79.0
  • Operating system: Ubuntu 18.04 & Mac OS Catalina
@niklasvh
Copy link
Owner

niklasvh commented Aug 8, 2020

Thanks for the repro! I was able to verify this not working as intended as well.

@niklasvh niklasvh added the Bug label Aug 8, 2020
niklasvh added a commit that referenced this issue Aug 8, 2020
@niklasvh
fix: image loading="lazy" fix #2312
8330e20
@niklasvh niklasvh mentioned this issue Aug 8, 2020
Merged
niklasvh added a commit that referenced this issue Aug 8, 2020
@niklasvh
fix: image loading="lazy" fix #2312 (#2314)
f23e6f6
oliveira-gust pushed a commit to oliveira-gust/html2canvas that referenced this issue May 24, 2021
@niklasvh @oliveira-gust
fix: image loading="lazy" fix niklasvh#2312 (niklasvh#2314)
eb3ede1
@lili21
Copy link

lili21 commented Sep 28, 2022

Run into the similar issue with safari 15.5.

the canvas generator just keep pending. the promise never fulfilled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: image loading="lazy" niklasvh/html2canvas
3 participants
@niklasvh @lili21 @frandemona