Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, proxy url's cannot have parameters.
This PR fixes/implements the following bugs/features
2098
Explain the motivation for making this change. What existing problem does the pull request solve?
If a proxy url contains a parameter such as:
http://abc.com/myproxy.jsp?myparam=foo
html2canvas will call the proxy using the following url:
http://abc.com/myproxy.jsp?myparam=foo?url=abc.com....
Notice there are two question marks in the url which is incorrect. The second parameter should begin with an ampersand.
The code had automatically put a question mark (?) after the proxy url. I fixed the code to check whether there is already a parameter at the end of the url. This was properly done in the the 0.5 version:
Test plan (required)
Pass a proxy url which ends with a parameter(s) as an option.
Code formatting
Please make sure that code adheres to the project code formatting. Running
npm run format
will automatically format your code correctly.Closing issues
Fixes #2098
Closes #2098