Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy url cannot have parameters #2098

Closed
mzand33 opened this issue Dec 26, 2019 · 0 comments · Fixed by #2100
Closed

Proxy url cannot have parameters #2098

mzand33 opened this issue Dec 26, 2019 · 0 comments · Fixed by #2100

Comments

@mzand33
Copy link
Contributor

mzand33 commented Dec 26, 2019

I am using a proxy url that contains a parameter:
http://abc.com/myproxy.jsp?myparam=foo

When I pass this proxy as an option to html2canvas, my proxy gets the following parameter:
myparam=foo?url=abc.com....
The reason is that the code automatically puts a question mark (?) after the proxy url. The code should check whether there is already a parameter at the end of the url. This was done in the the 0.5 version:
proxyUrl + (proxyUrl.indexOf("?") > -1 ? "&" : "?") + "url=" + encodeURIComponent(src)

Please fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant