migrate to react native 0.39 #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migrate to react native 0.39 fix error: attempted to set an invalid frame to inner scrollview
when textInput selected which will be under the keyboard, if it's the first user select, it' will remain under keyboard and scrollTo will not work. The problem aries from the fact that keyboard height is undefined until open in the iOS.
keyboardShouldPersistTaps= {true} is deprecated, using keyboardShouldPersistTaps='always' instead
remove flexGrow & flexBasis which is needed for react native 0.39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate to react native 0.39.
change flex:1 to flexGrow:1. This would fix the folowing error which occured on the keyboard open: attempted to set an invalid frame to inner scrollview