Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to react native 0.39 #35

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

izadmehr
Copy link

@izadmehr izadmehr commented Dec 4, 2016

migrate to react native 0.39.
change flex:1 to flexGrow:1. This would fix the folowing error which occured on the keyboard open: attempted to set an invalid frame to inner scrollview

migrate to react native 0.39

fix error: attempted to set an invalid frame to inner scrollview
when textInput selected which will be under the keyboard, if it's the first user select, it' will remain under keyboard and scrollTo will not work. The problem aries from the fact that keyboard height is undefined until open in the  iOS.
@izadmehr izadmehr changed the title Update SmartScrollView.js migrate to react native 0.39 Mar 25, 2017
keyboardShouldPersistTaps= {true} is deprecated, using keyboardShouldPersistTaps='always' instead
remove flexGrow & flexBasis which is needed for react native 0.39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant