Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade node to 8.12.0, upgrade npm packages (express, supertest, webpack, swagger-ui-dist) and fix memory problem #3953

Merged
merged 10 commits into from
Oct 23, 2018

Conversation

PieterGit
Copy link
Contributor

@PieterGit PieterGit commented Sep 29, 2018

also reimplement #3819 (webpack) without reformatting
Todo: test on Azure and confirm that nodejs 8.12.0 is available there.

@bassettb
Copy link
Contributor

I tested this out on my server running on a t3.micro with 1GB RAM. Unfortunately, it does not appear to fix the out of memory issue when running webpack. With swapfile off, it locks up the system like it did before. With swapfile on it uses all of the RAM and some swap.

@PieterGit
Copy link
Contributor Author

PieterGit commented Oct 13, 2018

@bassettb thanks for testing. I think I missed some of the changes in #3819 because of the reformatting.

@PieterGit
Copy link
Contributor Author

@bassettb I found I missed some of @nielsvanvelzen fixes. Now reapplied them with the Nightscout default formatting ident of 2. Can you please retest and report back if it works (or not). I'm running this branch on Heroku and can't find any problems.

@PieterGit PieterGit changed the title upgrade node to 8.12.0, and upgrade to supertest and webpack upgrade node to 8.12.0, upgrade npm pacakges (express, supertest, webpack, swagger-ui-dist) and fix memory problem Oct 13, 2018
@PieterGit
Copy link
Contributor Author

Updated to latest dev. Works on Heroku, but I would like to get confirmation that it now works on t3.micro with 1GB RAM or even in a situation with less RAM (e.g. 512MB). @bassettb could you test that and report back?

@PieterGit PieterGit changed the title upgrade node to 8.12.0, upgrade npm pacakges (express, supertest, webpack, swagger-ui-dist) and fix memory problem upgrade node to 8.12.0, upgrade npm packages (express, supertest, webpack, swagger-ui-dist) and fix memory problem Oct 14, 2018
…t Node 10 with Travis

- Due to Azure we had several supported npm version 5.6.x, 5.7.x, 5.8.x. Since Node 8.12.0 ships with npm 6.4.x we should stop supporting npm 5.x
- Azure currently does not have Node 8.12.x and probably does not work at this moment. Microsoft should stay current
- upgrades several packages, most notable mongodb
- move file-loader, expose-loader, style-loader to devDependencies
- remove webpack-command because it's not longer maintained and has security issues. Moving to webpack-cli
- upgrade version to 0.11.0-dev-20181022
resolves (node:24176) DeprecationWarning: current URL string parser is deprecated, and will be removed in a future version. To use the new parser, pass option { useNewUrlParser: true } to MongoClient.connect.
@PieterGit PieterGit merged commit 65372ab into nightscout:dev Oct 23, 2018
@PieterGit
Copy link
Contributor Author

Merged to dev. Don't know if this works under Azure which currently still has Node 8.11.1.

@bassettb
Copy link
Contributor

I tested it just now and it's still using over 750MB of RAM when running webpack.

@PieterGit PieterGit deleted the 201809_npm_node_update branch December 24, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants