Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on new checkmark and music note #20

Closed
gregwaehner opened this issue Jun 23, 2014 · 7 comments
Closed

Question on new checkmark and music note #20

gregwaehner opened this issue Jun 23, 2014 · 7 comments

Comments

@gregwaehner
Copy link
Contributor

feel like a stupid question - but what does the checkmark vs. the music note do now in the interface? If I click on them, they play the alarm once. Haven't been able to play the combinations from computer vs. phone, during high vs. low, etc.

I know the code is
✓♪

So I think it's just to test it manually... just confirming.

@bewest
Copy link
Member

bewest commented Jun 23, 2014

Press the button!

@bewest
Copy link
Member

bewest commented Jun 23, 2014

Some browsers have a security feature which requires user interaction before allowing sound. This provides the user interaction, and also provides a kind of "speaker check." Afterwards the alarms should sound.

@brianhanifin
Copy link
Contributor

It was a way that Jason came up with to allow mobile users to enable the alarms to play. Their purpose is definitely not clear, and we need to do something about that.

I have been tinkering with a button that is only displayed on mobile browsers, that reads "Enable Alarm", and disappears after being clicked. What do you guys think about that?

@gregwaehner
Copy link
Contributor Author

Makes sense. I am right now mostly using my computer browser, so when I pressed it, I got the sound. Waiting for my mobile to arrive. I think what you said makes a lot of sense. Or if it's easier (?), a "mouseover" that says "on a mobile device, click this to enable alarms."

  • G

From: Brian Hanifin [mailto:[email protected]]
Sent: Sunday, June 22, 2014 11:02 PM
To: nightscout/cgm-remote-monitor
Cc: Greg Waehner
Subject: Re: [cgm-remote-monitor] Question on new checkmark and music note (#20)

It was a way that Jason came up with to allow mobile users to enable the alarms to play. Their purpose is definitely not clear, and we need to do something about that.

I have been tinkering with a button that is only displayed on mobile browsers, that reads "Enable Alarm", and disappears after being clicked. What do you guys think about that?


Reply to this email directly or view it on GitHub #20 (comment) . https://github.com/notifications/beacon/7674953__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTExMTcxNCwiZGF0YSI6eyJpZCI6MzUyNTY5NzZ9fQ==--69f9e4ebbd79b672025419b67d3d632cacefae32.gif

@rnpenguin
Copy link
Contributor

I like a mobile only button idea.

@jasoncalabrese
Copy link
Member

I like pressing the link before bed to test the volume and make sure alarms work, but I agree the the interaction needs work

brianhanifin added a commit that referenced this issue Jul 23, 2014
Toolbar added + example settings forms in drawer
@brianhanifin
Copy link
Contributor

Closed: This link has been replaced by a toolbar button that looks like a speaker with a tooltip of "Alarm Test / Smartphone Enable". It is part of the experimental branch rebase/settings, that will eventually become part of the next release.

justinthomas pushed a commit to justinthomas/cgm-remote-monitor that referenced this issue Nov 29, 2022
bewest pushed a commit that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants