add: lazy loading modal solana selector #98

LukassF · 2024-02-21T14:21:48Z

No description provided.

vercel · 2024-02-21T14:21:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aleph-game	❌ Failed (Inspect)			Feb 26, 2024 9:26am

sdk/packages/selector-base/src/types.ts

NorbertBodziony · 2024-02-22T12:57:23Z

sdk/packages/selector-polkadot/src/adapter.ts

@@ -112,7 +113,7 @@ export class NightlyConnectAdapter implements Injected {
  set walletsList(list: IPolkadotWalletListItem[]) {
    this._walletsList = list
    if (this._modal) {
-      this._modal.walletsList = list
+      this._modal.walletsList = list as IWalletListItem[]


do we need this maybe IPolkadotWalletListItem is now redundant ?

sdk/packages/selector-polkadot/src/detection.ts

NorbertBodziony · 2024-02-22T12:58:37Z

sdk/packages/selector-polkadot/src/detection.ts

    walletsData[wallet.name.toLocaleLowerCase()] = {
      slug: wallet.name,
      name: wallet.name,
-      icon: wallet.icon as string,
-      link: '',
-      deeplink: null,
+      image: {
+        default: wallet.icon as string,
+        sm: wallet.icon as string,
+        md: wallet.icon as string,
+        lg: wallet.icon as string
+      },
+      desktop: null,
+      mobile: null,
      recent: recentWalletName === wallet.name,
      detected: true,
      injectedWallet: wallet,
+      homepage: '',
      walletType: 'hybrid'
    }


do you have to unify types?

sdk/packages/selector-solana/src/adapter.ts

NorbertBodziony · 2024-02-22T15:06:11Z

sdk/bindings/WalletMetadata.ts

+import type { Deeplink } from './Deeplink'
+import type { Images } from './Images'
+import type { Network } from './Network'
+import type { Platform } from './Platform'
+import type { Version } from './Version'
+import type { WalletType } from './WalletType'

-export interface WalletMetadata { slug: string, name: string, description: string, homepage: string, chains: Array<Network>, version: Version, walletType: WalletType, mobile: Deeplink | null, desktop: Deeplink | null, image: Images, app: Record<Platform, string>, injectPath: Record<Network, string>, lastUpdatedTimestamp: bigint, }
+export interface WalletMetadata {
+  slug: string
+  name: string
+  description?: string
+  homepage?: string
+  chains?: Array<Network>
+  version?: Version
+  walletType: WalletType
+  mobile: Deeplink | null
+  desktop: Deeplink | null
+  image: Images
+  app?: Record<Platform, string>
+  injectPath?: Record<Network, string>
+  lastUpdatedTimestamp?: bigint
+}


DO NOT FORMAT GENERATE FILES

NorbertBodziony · 2024-02-22T15:07:11Z

sdk/packages/selector-polkadot/src/detection.ts

-    walletsData[wallet.slug.toLocaleLowerCase()] = wallet
+    walletsData[wallet.slug.toLocaleLowerCase()] = {
+      ...wallet,
+      recent: recentWalletName === wallet.name


is recent part of api ?

NorbertBodziony · 2024-02-22T17:14:13Z

sdk/packages/selector-base/src/types.ts

+export interface WalletMetadata extends Partial<WalletMetadataOriginal> {
+  slug: string
+  name: string
+  walletType: WalletType
+  mobile: Deeplink | null
+  desktop: Deeplink | null
+  image: Images
+}
+


WHAT ? remove this

But wouldnt it then force me to pass all of the fields such as homepage, version, app etc. in for example polkadot selector detection file?
walletsData[wallet.name.toLocaleLowerCase()] = { slug: wallet.name, name: wallet.name, image: { default: wallet.icon as string, sm: wallet.icon as string, md: wallet.icon as string, lg: wallet.icon as string }, desktop: null, mobile: null, recent: recentWalletName === wallet.name, detected: true, injectedWallet: wallet, walletType: 'hybrid' }

NorbertBodziony · 2024-02-22T17:14:23Z

sdk/packages/selector-base/src/types.ts

@@ -2,8 +2,8 @@ import { type AppBaseInitialize } from '@nightlylabs/nightly-connect-base'
 import { type Deeplink } from '@nightlylabs/nightly-connect-base/dist/types/bindings/Deeplink'
 import { type Wallet } from '@wallet-standard/core'
 import { type WalletType } from '../../../bindings/WalletType'
-import { type WalletMetadata } from '../../../bindings/WalletMetadata'
-export { type WalletMetadata } from '../../../bindings/WalletMetadata'
+import { type WalletMetadata as WalletMetadataOriginal } from '../../../bindings/WalletMetadata'


just export this

NorbertBodziony · 2024-02-22T17:14:50Z

sdk/packages/selector-base/src/detection.ts

+import { type WalletMetadata, type IWalletListItem, type MetadataWallet } from './types'

 export const getWalletsList = (
  presetList: WalletMetadata[],


we gonna remove this method each selecto will define it for itself

NorbertBodziony · 2024-02-22T17:15:15Z

sdk/packages/selector-polkadot/src/detection.ts

+export interface IPolkadotWalletListItem extends WalletMetadata {
+  recent?: boolean
+  detected?: boolean
  injectedWallet?: PolkadotWalletInjected
 }


WalletMetadata should be one from bindings
so you almost got it

github-actions · 2024-02-23T12:34:27Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-ohcd4aa1e-nightlylabs.vercel.app

github-actions · 2024-02-23T12:36:14Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-8w7z837cu-nightlylabs.vercel.app

NorbertBodziony · 2024-02-23T12:35:33Z

sdk/packages/selector-polkadot/src/adapter.ts

@@ -163,7 +161,7 @@ export class NightlyConnectAdapter implements Injected {
    )
    if (!adapter._connectionOptions.disableModal) {
      adapter._modal = new NightlyConnectSelectorModal(
-        adapter.walletsList,
+        adapter.walletsList as IWalletListItem[],


do we need as also
why us IWalletListItem

NorbertBodziony · 2024-02-23T12:36:34Z

sdk/packages/selector-solana/src/adapter.ts

+                // reject(new Error('Connecting takes too long'))
+                // TODO we need to have a way to show error on modal


show error ?

github-actions · 2024-02-23T12:37:48Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-qwmhn8fha-nightlylabs.vercel.app

github-actions · 2024-02-23T12:39:41Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-fi8bd6a0h-nightlylabs.vercel.app

github-actions · 2024-02-26T14:19:07Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-lf1vuxs3h-nightlylabs.vercel.app

github-actions · 2024-02-26T14:20:56Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-31w9a9pi5-nightlylabs.vercel.app

github-actions · 2024-02-26T14:22:31Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-b265nl3e7-nightlylabs.vercel.app

github-actions · 2024-02-26T14:24:05Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-a52nhe86l-nightlylabs.vercel.app

github-actions · 2024-02-26T16:48:21Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-ch98wdpzw-nightlylabs.vercel.app

github-actions · 2024-02-26T16:50:08Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-pk7m199u9-nightlylabs.vercel.app

github-actions · 2024-02-27T10:44:14Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-maeyizs9w-nightlylabs.vercel.app

github-actions · 2024-02-27T10:46:02Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-mh6m75uua-nightlylabs.vercel.app

github-actions · 2024-02-27T11:45:31Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-jwhinmaqk-nightlylabs.vercel.app

github-actions · 2024-02-27T11:47:03Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-cfjo59lxe-nightlylabs.vercel.app

github-actions · 2024-02-27T14:05:01Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-obdse9vp4-nightlylabs.vercel.app

github-actions · 2024-02-27T14:06:44Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-kwf4rygtu-nightlylabs.vercel.app

github-actions · 2024-02-27T14:22:16Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-7ihozmb87-nightlylabs.vercel.app

github-actions · 2024-02-27T14:23:49Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-lssubnbzq-nightlylabs.vercel.app

github-actions · 2024-02-27T16:27:23Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-kptggqjyv-nightlylabs.vercel.app

github-actions · 2024-02-27T16:28:56Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-jofg7u0xe-nightlylabs.vercel.app

github-actions · 2024-02-27T16:38:10Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-l1wfgzxik-nightlylabs.vercel.app

github-actions · 2024-02-27T16:39:58Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-91m832cpi-nightlylabs.vercel.app

github-actions · 2024-02-28T10:34:28Z

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview:	https://connect-95ghg6fws-nightlylabs.vercel.app

github-actions · 2024-02-28T10:36:02Z

🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙

✅ Preview:	https://nightly-connect-storybook-6jxwo03sm-nightlylabs.vercel.app

add: lazy loading modal solana selector

9395c69

add: fetch all wallets and change type

5678d3c

vercel bot had a problem deploying to Preview February 22, 2024 11:05 Failure

fix: version

5bab9f5

vercel bot had a problem deploying to Preview February 22, 2024 11:06 Failure

add: solana change event listener and emitter

bb51fc0

vercel bot had a problem deploying to Preview February 22, 2024 12:53 Failure

NorbertBodziony requested changes Feb 22, 2024

View reviewed changes

fix: listeners

bba5a77

vercel bot had a problem deploying to Preview February 22, 2024 14:40 Failure

LukassF added 2 commits February 22, 2024 15:49

Merge branch 'main' into solana_selector_lazy

f26cbb6

fix; pull main

bd6a67e

vercel bot had a problem deploying to Preview February 22, 2024 15:00 Failure

NorbertBodziony requested changes Feb 22, 2024

View reviewed changes

fix: decoupling types

de1f563

vercel bot had a problem deploying to Preview February 22, 2024 15:35 Failure

NorbertBodziony requested changes Feb 22, 2024

View reviewed changes

fix: partial and moved getSolanaWalletsList method to dedicated file

11fce53

vercel bot had a problem deploying to Preview February 23, 2024 10:53 Failure

fix: remove partial

e012fc4

vercel bot had a problem deploying to Preview February 23, 2024 12:32 Failure

remove redundant imports

ae9b42a

github-actions bot added the deployed label Feb 23, 2024

vercel bot had a problem deploying to Preview February 23, 2024 12:36 Failure

NorbertBodziony requested changes Feb 23, 2024

View reviewed changes

add: external modal for solana

cf5764e

fix: added listener to the newly created app when disconnecting

3bb97c4

fix: update wallets list on disconnect

44295fb

add try catch and remove filter on modal

262958d

fix solana

d4c6d5b

add try catch blocks

8953340

fix: polkadot detection

299798c

fix: polkadot detection v2

64474f3

NorbertBodziony merged commit e4ea8a9 into main Feb 28, 2024
4 checks passed

NorbertBodziony deleted the solana_selector_lazy branch February 28, 2024 11:09

		// reject(new Error('Connecting takes too long'))
		// TODO we need to have a way to show error on modal

add: lazy loading modal solana selector #98

add: lazy loading modal solana selector #98

Conversation

LukassF commented Feb 21, 2024

vercel bot commented Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2024

github-actions bot commented Feb 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2024

github-actions bot commented Feb 23, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 28, 2024

github-actions bot commented Feb 28, 2024

vercel bot commented Feb 21, 2024 •

edited

Loading