add: polkadot selector lazy loading without session id #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙
|
NorbertBodziony
requested changes
Feb 15, 2024
| } | ||
|
|
||
| // fallback when connecting takes too long | ||
| if (checks > 1000) { |
There was a problem hiding this comment.
max load should be 5 sec
| // opening modal and waiting for sessionId | ||
| if (this._modal) { | ||
| this._modal.onClose = () => { | ||
| clearInterval(intervalId) |
There was a problem hiding this comment.
interval might not exist
Comment on lines
480
to
485
| intervalId = setInterval((): void => { | ||
| checks++ | ||
| if (this._app && this._modal) { | ||
| this._modal.sessionId = this._app.sessionId | ||
| clearInterval(intervalId) | ||
| } |
There was a problem hiding this comment.
how can we clear something that might not yet exist + return
Comment on lines
551
to
569
| this._app.on('userConnected', () => { | ||
| try { | ||
| if (this._chosenMobileWalletName) { | ||
| persistRecentStandardWalletForNetwork(this._chosenMobileWalletName, this.network) | ||
| } else { | ||
| clearRecentStandardWalletForNetwork(this.network) | ||
| } | ||
| if (!this._app || this._app.accounts.activeAccounts.length <= 0) { | ||
| this._connecting = false | ||
| // If user does not pass any accounts, we should disconnect | ||
| this.disconnect() | ||
| } | ||
| this._connected = true | ||
| this._connecting = false | ||
| this._appSessionActive = true | ||
| this._modal?.closeModal() | ||
| resolve() | ||
| } catch { | ||
| this.disconnect() |
There was a problem hiding this comment.
this is missing when we are "loading"
this code is in wrong place
|
🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 STORYBOOK 🤙🤙🤙🤙
|
|
🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙
|
NorbertBodziony
approved these changes
Feb 20, 2024
| // opening modal and waiting for sessionId | ||
| if (this._modal) { | ||
| this._modal.onClose = () => { | ||
| if (intervalId) clearInterval(intervalId) |
| @@ -449,6 +449,106 @@ export class NightlyConnectAdapter implements Injected { | |||
| return | |||
| } | |||
|
|
|||
| let intervalId: NodeJS.Timeout | |||
There was a problem hiding this comment.
rename to loadingInterval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.