Merge pull request #198 from nightly-labs/passkey_fixed

passkey_fixed
nightly-labs · Sep 3, 2024 · 1ad8eb7 · 1ad8eb7
2 parents 716851f + 44b4743
commit 1ad8eb7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/sdk/packages/cloud/package.json b/sdk/packages/cloud/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nightlylabs/nightly-cloud",
-  "version": "0.0.9",
+  "version": "0.0.13",
   "type": "module",
   "exports": {
     ".": {

diff --git a/sdk/packages/cloud/src/app.ts b/sdk/packages/cloud/src/app.ts
@@ -202,7 +202,10 @@ export class NightlyCloud {
       EndpointType.Public,
       request
     )) as HttpRegisterWithPasskeyStartResponse
-
+    // @ts-expect-error Fixes in direct parsing of the response
+    response.publicKey.challenge = Buffer.from(response.publicKey.challenge, 'base64')
+    // @ts-expect-error Fixes in direct parsing of the response
+    response.publicKey.user.id = Buffer.from(response.publicKey.user.id, 'base64')
     return response
   }
 
@@ -266,7 +269,14 @@ export class NightlyCloud {
       EndpointType.Public,
       request
     )) as HttpLoginWithPasskeyStartResponse
-
+    // @ts-expect-error Fixes in direct parsing of the response
+    response.publicKey.challenge = Buffer.from(response.publicKey.challenge, 'base64')
+    if (response.publicKey.allowCredentials) {
+      response.publicKey.allowCredentials.forEach((c) => {
+        // @ts-expect-error  Fixes in direct parsing of the response
+        c.id = Buffer.from(c.id, 'base64')
+      })
+    }
     return response
   }
 
@@ -337,6 +347,10 @@ export class NightlyCloud {
       EndpointType.Public,
       request
     )) as HttpResetPasskeyStartResponse
+    // @ts-expect-error Fixes in direct parsing of the response
+    response.publicKey.challenge = Buffer.from(response.publicKey.challenge, 'base64')
+    // @ts-expect-error Fixes in direct parsing of the response
+    response.publicKey.user.id = Buffer.from(response.publicKey.user.id, 'base64')
 
     return response
   }
@@ -363,6 +377,10 @@ export class NightlyCloud {
       EndpointType.Private,
       {}
     )) as HttpAddNewPasskeyStartResponse
+    // @ts-expect-error Fixes in direct parsing of the response
+    response.publicKey.challenge = Buffer.from(response.publicKey.challenge, 'base64')
+    // @ts-expect-error Fixes in direct parsing of the response
+    response.publicKey.user.id = Buffer.from(response.publicKey.user.id, 'base64')
 
     return response
   }
@@ -567,10 +585,10 @@ export class NightlyCloud {
       EndpointType.Private
     )) as HttpGetPasskeyChallengeResponse
 
-    // @ts-expect-error
+    // @ts-expect-error Fixes in direct parsing of the response
     response.publicKey.challenge = Buffer.from(response.publicKey.challenge, 'base64')
     response.publicKey.allowCredentials?.forEach((c) => {
-      // @ts-expect-error
+      // @ts-expect-error Fixes in direct parsing of the response
       c.id = Buffer.from(c.id, 'base64')
     })
     return response