Added Test::DescribeMe as a TEST_REQUIRES

nigelhorne · Sep 19, 2024 · b96bc8a · b96bc8a
1 parent c34b563
commit b96bc8a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -21,20 +21,16 @@ jobs:
             sudo apt-get update && \
             sudo apt-get upgrade && \
             sudo apt-get install --assume-yes --quiet \
-              --no-install-suggests --no-install-recommends \
-              perl cpanminus
+              perl cpanminus libtest-needs-perl libtest-most-perl
       - run:
           name: Perl version
           command: perl --version
       - run:
           name: App::cpanminus version
           command: cpanm --version
-      - run:
-          name: Prepare testing environment
-          command: sudo cpanm -iqn Test::Most Test::Needs
       - run:
           name: Install dependancies
-          command: sudo cpanm -iqn --installdeps .
+          command: sudo cpanm -ivn --installdeps . || cat /root/.cpan/work/*/build.log
       - run:
           name: Make Module
           command: sudo chown -R circleci . && perl Makefile.PL && make

diff --git a/Makefile.PL b/Makefile.PL
@@ -70,6 +70,7 @@ WriteMakefile(
 	PL_FILES => (defined($ENV{'AUTOMATED_TESTING'}) ? {} : {'bin/create_db.PL' => 'bin/create_db'}),
 	TEST_REQUIRES => {
 		'Test::Carp' => 0,
+		'Test::DescribeMe' => 0,
 		'Test::Most' => 0,
 		'Test::NoWarnings' => 0,
 		'Test::Needs' => 0,

diff --git a/lib/Genealogy/ObituaryDailyTimes.pm b/lib/Genealogy/ObituaryDailyTimes.pm
@@ -152,7 +152,7 @@ sub _get_params
 
 	if(ref($_[0]) eq 'HASH') {
 		%rc = %{$_[0]};
-	} elsif(scalar(@_) % 2 == 0) {
+	} elsif((scalar(@_) % 2) == 0) {
 		%rc = @_;
 	} elsif(scalar(@_) == 1) {
 		if(defined($default)) {