Fix Appveyor

nigelhorne · Sep 13, 2024 · 1d85f41 · 1d85f41
1 parent 5436965
commit 1d85f41
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/Genealogy/ObituaryDailyTimes.pm b/lib/Genealogy/ObituaryDailyTimes.pm
@@ -53,14 +53,15 @@ sub new {
 		return bless { %{$class}, %args }, ref($class);
 	}
 
-	if(!defined((my $directory = ($args{'directory'} || $Database::Abstraction->{'directory'})))) {
+	my $directory = $args{'directory'} || $Database::Abstraction->{'directory'};
+	if(!defined($directory)) {
 		# If the directory argument isn't given, see if we can find the data
-		$directory ||= Module::Info->new_from_loaded(__PACKAGE__)->file();
+		$directory = Module::Info->new_from_loaded(__PACKAGE__)->file();
 		$directory =~ s/\.pm$//;
 		$args{'directory'} = File::Spec->catfile($directory, 'data');
 	}
-	if(!-d $args{'directory'}) {
-		Carp::carp(__PACKAGE__, ': ', $args{'directory'}, ' is not a directory');
+	if(!-d $directory) {
+		Carp::carp(__PACKAGE__, ": $directory is not a directory");
 		return;
 	}