Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Defining A Custom Thousand Separator Format #30

Merged
merged 10 commits into from
Dec 24, 2021
Merged

Enable Defining A Custom Thousand Separator Format #30

merged 10 commits into from
Dec 24, 2021

Commits on Dec 21, 2021

  1. Parse Dates Surrounded by Spaces Without Exception 

    When a date is surrounded by space, the date library fails to parse it
This commit is to trim the date field before parsing date fields.
    @ahmedmsvb
    ahmedmsvb committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    a5fe27e View commit details
    Browse the repository at this point in the history

  2. Enable Defining A Custom Thousand Separator Format 

    Java Script parseFloat method ignores comma when parsing a string number
For some locales, the amount is written in format 1,234.56
The above will not parse correctly unless ynab-buddy was instructed with the correct separator format
    @ahmedmsvb
    ahmedmsvb committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    294b55a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/nielsmaerten/ynab-buddy int… 

    …o nielsmaerten-main
    @ahmedmsvb
    ahmedmsvb committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    bb49fae View commit details
    Browse the repository at this point in the history

  4. git push origin feature/allow-custom-thousand-separator-for-amountsMe… 

    …rge branch 'nielsmaerten-main' into feature/allow-custom-thousand-separator-for-amounts
    @ahmedmsvb
    ahmedmsvb committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    3b20ac0 View commit details
    Browse the repository at this point in the history

  5. Fix codestyle issues

    @ahmedmsvb
    ahmedmsvb committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    030d430 View commit details
    Browse the repository at this point in the history

  6. test(parseAmount): test different formats

    @nielsmaerten
    nielsmaerten committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    64225b4 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. style: code cleanup & backwards compatibility

    @nielsmaerten
    nielsmaerten committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    6c35f24 View commit details
    Browse the repository at this point in the history

  2. fix: cleanup code and add tests 

    - Add a test that tries parsing amounts in a bunch of different formats
- Clean up code style a bit
    @nielsmaerten
    nielsmaerten committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    d424a13 View commit details
    Browse the repository at this point in the history

  3. docs: update docs and default config

    @nielsmaerten
    nielsmaerten committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    88bd022 View commit details
    Browse the repository at this point in the history

  4. chore: fix typo

    @nielsmaerten
    nielsmaerten committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    95b087d View commit details
    Browse the repository at this point in the history