feat: skip transaction upload if no transactions are parsed #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 95.30% 95.19% -0.12%
==========================================
Files 13 13
Lines 1236 1270 +34
Branches 104 68 -36
==========================================
+ Hits 1178 1209 +31
- Misses 54 61 +7
+ Partials 4 0 -4 ☔ View full report in Codecov by Sentry. |
|
Great addition! Thanks 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have multiple bank files that I automatically export from my banking software, but they always cover only the last 10 days. As a result, some files are empty CSV files. While these files still get parsed, I encounter an error during the YNAB upload.
This change skips the transaction upload if the transactions array is empty.