Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseOpinionsRowProvider -- useless class and hence should be removed [refactoring IOUtils] #282

Closed
1 task done
nicolay-r opened this issue Feb 15, 2022 · 0 comments
Closed
1 task done

BaseOpinionsRowProvider -- useless class and hence should be removed [refactoring IOUtils] #282

nicolay-r opened this issue Feb 15, 2022 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Feb 15, 2022 •
edited
Loading

  • Consider this as an optional step of the pipeline, i.e. separated it from samples.

Covers refactoring for:
DefaultBertIOUtils and DefaultNetworkIOUtils and hence for BaseIOUtils

image
@nicolay-r nicolay-r self-assigned this Feb 15, 2022
@nicolay-r nicolay-r mentioned this issue May 31, 2022
Closed
@nicolay-r nicolay-r changed the title BaseOpinionsRowProvider -- might be removed BaseOpinionsRowProvider -- useless class and hence should be removed Jun 3, 2022
nicolay-r added a commit that referenced this issue Jul 12, 2022
@nicolay-r
#362 related. We disable opinions preparation by default. (#282 related)
85b0952
@nicolay-r nicolay-r changed the title BaseOpinionsRowProvider -- useless class and hence should be removed BaseOpinionsRowProvider -- useless class and hence should be removed Jul 30, 2022
@nicolay-r nicolay-r added the enhancement New feature or request label Jul 30, 2022
nicolay-r added a commit that referenced this issue Jul 30, 2022
@nicolay-r
#282 related fix. Removed non utlized method. (#373 related.)
3d3280b
nicolay-r added a commit that referenced this issue Jul 31, 2022
@nicolay-r
#282 related refactoring.
c2fd9d7
nicolay-r added a commit that referenced this issue Jul 31, 2022
@nicolay-r
#282 related refactoring. Now we specialize only on parts.
e6a98ae
nicolay-r added a commit that referenced this issue Jul 31, 2022
@nicolay-r
#282 related refactoring. Adopt embedding io and sample based instead…
c4f942e 
… of model related one
nicolay-r added a commit that referenced this issue Jul 31, 2022
@nicolay-r
#282 simplified passed parameters
ca1e647
nicolay-r added a commit that referenced this issue Aug 1, 2022
@nicolay-r
#282 removing dependecy from IOUtils for embedding related data. Rela…
3755b75 
…ted to #342
nicolay-r added a commit that referenced this issue Aug 1, 2022
@nicolay-r
#282 related. Removing usage and serialization of opinions
5db2391
nicolay-r added a commit that referenced this issue Aug 1, 2022
@nicolay-r
#282 related fix. #252 related in terms of simplification
b9e2d84
nicolay-r added a commit that referenced this issue Aug 1, 2022
@nicolay-r
#282 related refactoring
9d3af80
This was referenced Aug 1, 2022
Closed
Closed
nicolay-r added a commit that referenced this issue Aug 2, 2022
@nicolay-r
#342, #379 related, and #282. Removed non used properties and paramet…
6a23d18 
…ers.
@nicolay-r nicolay-r changed the title BaseOpinionsRowProvider -- useless class and hence should be removed BaseOpinionsRowProvider -- useless class and hence should be removed [refactoring IOUtils] Aug 2, 2022
@nicolay-r nicolay-r mentioned this issue Aug 2, 2022
Closed
4 tasks
nicolay-r added a commit that referenced this issue Aug 17, 2022
@nicolay-r
#282 removed opinions
17a314d
@nicolay-r nicolay-r mentioned this issue Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r