Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpinionCollectionsProvider -- serialization should not be a part of this class #210

Closed
nicolay-r opened this issue Oct 2, 2021 · 0 comments
Closed

OpinionCollectionsProvider -- serialization should not be a part of this class #210

nicolay-r opened this issue Oct 2, 2021 · 0 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

AREkit/arekit/common/opinions/provider.py

Line 6 in b45fd34

def serialize(self, collection, target, labels_formatter, error_on_non_supported):

@nicolay-r nicolay-r added enhancement New feature or request critical labels Oct 2, 2021
@nicolay-r nicolay-r self-assigned this Oct 2, 2021
nicolay-r added a commit that referenced this issue Oct 20, 2021
@nicolay-r
Removed non utilized parameter (#210)
df0b0a6
nicolay-r added a commit that referenced this issue Oct 20, 2021
@nicolay-r
#210 -- switched to reader by a given "target". Related refactoring.
c9d69e0
nicolay-r added a commit that referenced this issue Oct 24, 2021
@nicolay-r
#210, refactoring.
775571c
nicolay-r added a commit that referenced this issue Oct 24, 2021
@nicolay-r
#210, separated converting functions.
9e4e3a9
nicolay-r added a commit that referenced this issue Dec 27, 2021
@nicolay-r
Fixed: no need to adopt decode for str type (#210 associated), #160.
bc3b616
nicolay-r added a commit that referenced this issue Dec 30, 2021
@nicolay-r
#210 related
e823d95
@nicolay-r nicolay-r mentioned this issue Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r