Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new config "CtagsOptions" #14

Merged
merged 1 commit into from
Nov 5, 2017

Conversation

Fmajor
Copy link

@Fmajor Fmajor commented Nov 3, 2017

this should fix issue #13

@nicolashainaux
Copy link
Owner

This looks good 👍
I will merge it.
Have you tested it with several arguments, like separated by commas? (If not, I think it's still easy to fix).

@nicolashainaux nicolashainaux merged commit a630166 into nicolashainaux:master Nov 5, 2017
@nicolashainaux nicolashainaux added this to the 0.15.5 milestone Nov 5, 2017
@Fmajor
Copy link
Author

Fmajor commented Nov 6, 2017

i did not make many tests, because this option is a global option.
if i can make different options for different file extensions, that will be better

@Fmajor
Copy link
Author

Fmajor commented Nov 6, 2017

i don't know what happened, but the plugin have different behavior in dev and normal mode
image
this is in dev mode (load plugin from my local dev folder)
the title "CtagsOptions" is right and it works

image
this is in normal mode (not in dev mode), i update the plugin to the latest version, but the configure title "Zz Ctags Options" is wrong, and the plugin does not work as i expect (the option is ignored).

@nicolashainaux
Copy link
Owner

Hum, I had no more time yesterday and couldn't publish it (I'll try asap but I don't want to publish in a hurry and make something wrong; I still need to merge it with other local changes and push everything back, add a description paragraph in the README and then publish).

So it's actually not a suprise that it's ignored in normal mode (it's just weird that the option still shows up in normal mode, I guess there's a little bug in atom).

@Fmajor
Copy link
Author

Fmajor commented Nov 6, 2017

that's weird...
I'm working on the dev mode, it's fine for me
take your time

nicolashainaux added a commit that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants